ADFlib icon indicating copy to clipboard operation
ADFlib copied to clipboard

Improve adf_salv (salvage)

Open t-w opened this issue 1 year ago • 3 comments

The adf_salv module, with the very useful undel functions, needs improvements in terms of:

  • memory management (ie. memory leaks)
  • error checking (eg. undeleting things not checking if the blocks are read correctly)

(Since in some cases possibly the error check should be avoided (even if a checksum is not correct, data could be recovered), the issue is created to take notes/comments on this).

t-w avatar Jun 09 '23 10:06 t-w

Inspiration was disksalv https://www.nightvzn.net/portfolio/web/amiga_monitor/archives/1_5html/disksalv.htm

lclevy avatar Jun 09 '23 11:06 lclevy

Good to know!

t-w avatar Jun 09 '23 15:06 t-w

There is still (at least...) one thing left:

  • adfUndelFile(): add reverting adfCreateEntry in case adfAddInCache fails. While this should be relatively rare case, nevertheless, it should be fixed/improved.

t-w avatar May 18 '24 23:05 t-w