Louis Charette

Results 133 comments of Louis Charette

Does library like Dropzone use `formData` to process uploads? If they do, they probably don't support checkbox anyway and won't be of any help, but if they don't use formData,...

Another way could be to append each form input to an empty `formData` ? See: https://stackoverflow.com/questions/5392344/sending-multipart-formdata-with-jquery-ajax

Could be worth cloning the PHPMailer object at the beginning of both `send` method ? https://github.com/userfrosting/sprinkle-core/blob/50eb7feb6973ce281ed0dab7b4f1649957b9bb72/app/src/Mail/Mailer.php#L94

On a side note, this line sound useless, since the message it not returned ? https://github.com/userfrosting/sprinkle-core/blob/50eb7feb6973ce281ed0dab7b4f1649957b9bb72/app/src/Mail/Mailer.php#L123

> On a side note, this line sound useless, since the message it not returned ? > > https://github.com/userfrosting/sprinkle-core/blob/50eb7feb6973ce281ed0dab7b4f1649957b9bb72/app/src/Mail/Mailer.php#L123 Hum, this actually work because [objects are passed as reference](https://stackoverflow.com/a/9696799/445757). Still,...

The clone approach does work. I tested it here : https://github.com/userfrosting/sprinkle-core/commit/cd31acb270851dd8d16b4ff8a1ab1ef8924cb1de#diff-5df6992aec5c88a4fa0356edd529a496241b08eec82b924924c8bf5f0d1d5d3eR107 Just note this commit is targeted toward 5.0 only ;). If it's an immediate issue on your side, it...

N.B.: This will need to be properly (manually) tested to make sure the existing token (if any) are not impacted and Captcha still properly working.

Fun fact, `notFoundHandler ` [is gone in Slim 4](https://stackoverflow.com/questions/57648078/replacement-for-notfoundhandler-setting/57648863). Slim4 returns [it's own exceptions](https://www.slimframework.com/docs/v4/middleware/error-handling.html#new-http-exceptions), which means UF exception won't be used in the future... It doesn't seams that bad, until...

For V5, User facing messages are now tied to the exception in the handler based on the status code (eg `ERROR.403.TITLE`) since Slim's Exception will be used (can't overwrite them)....

Looks like a limitation on [Monolog side](https://github.com/Seldaek/monolog/blob/bec314a9c14ce8a40650cf13923f5941ef1bfe0a/src/Monolog/Logger.php#L487). We would need to encapsulate the debug method so we convert string to array manually. FYI, I usually do, with whatever kind of...