live-chart icon indicating copy to clipboard operation
live-chart copied to clipboard

Published 20 hours ago • verified publisher icon lcallarec

Make XAxis and YAxis extend an Axis class

Open pongloongyeat opened this issue 4 years ago • 3 comments

As title implies. All tests passed.

pongloongyeat avatar Jan 27 '21 06:01 pongloongyeat

Thanks for your contribution. Looks good, but I just would like to take time to give a look at this change https://github.com/lcallarec/live-chart/pull/28/commits/80a81e2046c4ed62cd2079d8ad7cb8efee895d67#diff-8fc8cc80e5f6ea3a23ffe66932e4d44d1bfaadba3bf8bf0eb43a1d2e66dfff54L34. I'm not sure if it can broke something or not. Even if the coverage is pretty good, everything is not unit tested yet.

lcallarec avatar Jan 27 '21 12:01 lcallarec

Ahhh I may want to give it a default value then.

pongloongyeat avatar Jan 28 '21 06:01 pongloongyeat

@lcallarec take your time. For now, I'll give it a default value so it can fallback to something. I believe YAxis uses a tick_interval of 60.

pongloongyeat avatar Jan 28 '21 12:01 pongloongyeat