lbry-sdk icon indicating copy to clipboard operation
lbry-sdk copied to clipboard

Better Support blocklist reposting

Open jessopb opened this issue 2 years ago • 5 comments

We propose the general principle that claim_list should always be able to show you your claims and their references in entirety (with exception of sd hash) resolve if blocked returns the error, respecting the block list. claim_search filters out blocked claims.

Currently, it seems claim_list with --resolve does not resolve reposted claims. Currently, we cannot look up a particular blocked item or channel with a blocked item in the event of a dispute/unblock.

  • [ ] claim_list --resolve includes reposted claims (except sd hash)(even if blocked) and their signing channels
  • [ ] claim_list --reposted_claim_id --resolve (implied?) returns a repost of the claim_id
  • [ ] claim_list --reposted_channel_id returns all reposts for claims in the channel.
  • [ ] claim_list output for reposts should have claim_id rather than claim_hash bytes (edit: rather? or both? - Jeremy).

jessopb avatar Sep 20 '22 16:09 jessopb

@eukreign this ought to be a priority after current work is complete. Please discuss with @jessopb and/or bring up on next stand up if there are questions here.

kauffj avatar Sep 26 '22 15:09 kauffj

Does it make sense to resolve and then if necessary, do the blockchain lookup and filter out the sdhash if resolved returned blocking error?

jessopb avatar Sep 26 '22 15:09 jessopb

@kauffj I would need more info on how this would work. Currently claim_list --resolve simply calls resolve in the background to provide the claim list with extra resolved metadata. If a claim is blocked from being resolved then claim_list --resolve couldn't resolve it just as plain resolve can't resolve it.

eukreign avatar Sep 26 '22 18:09 eukreign

Use lbry.wallet.Network.get_claim.by_id for the repost, Then/and resolve the url to know if you should filter.

jessopb avatar Sep 26 '22 18:09 jessopb

https://github.com/lbryio/lbry-sdk/issues/3676 made an issue for fourth bullet point.

jessopb avatar Sep 27 '22 19:09 jessopb