lbry-sdk icon indicating copy to clipboard operation
lbry-sdk copied to clipboard

Update `staked_amount` to include stakes inside a channel in that channels amount

Open kauffj opened this issue 4 years ago • 8 comments

  • effective_amount stays as is
  • staked_amount is a new field that
    • is sum of staked lbc for a claim and all its supports
    • is not affected by activation delay
    • for a channel, also includes the staked_amount of all content claims (not recursive, doesn't descend into channels signed by channels) in that channel

kauffj avatar Oct 26 '20 17:10 kauffj

  • add new field to resolve for channels that lists the sum effective amounts for a channel's content claims
  • make sure you can sort by that field (via claim_search)
  • potentially have effective_amount changes take effect immediately when accessed via claim_search (or via special flag)

lyoshenka avatar Oct 26 '20 20:10 lyoshenka

sorting is less important, just getting the info on resolve is the most useful for the first feature

kauffj avatar Nov 09 '20 21:11 kauffj

blocking https://github.com/lbryio/lbry-desktop/issues/4919

kauffj avatar Nov 16 '20 20:11 kauffj

this is basically now the only missing piece in having the naming/bidding system user experience be far more compelling (searching changes and reposting changes are done app side)

kauffj avatar Dec 04 '20 15:12 kauffj

@kauffj Last we discussed this, we mentioned that a claim should be its total supports, plus its channel's total supports. This way new content from a known credible source gets the right bump by just being from a credible source. Not just its own supports. Is that no longer the case or did it just get lost in the shuffle?

tiger5226 avatar Dec 15 '20 03:12 tiger5226

There's no way to stop someone from creating another channel/account and supporting it from there, so I don't think it makes sense to force it. Plus, we want publishers to self support as well.

tzarebczan avatar Dec 15 '20 15:12 tzarebczan

needs to be ported to master after jack's stuff is merged

lyoshenka avatar Apr 06 '21 16:04 lyoshenka

I'm going to start looking at this now

eggplantbren avatar Oct 25 '21 21:10 eggplantbren