lbry-desktop icon indicating copy to clipboard operation
lbry-desktop copied to clipboard

Remove block list apis

Open jessopb opened this issue 2 years ago • 2 comments

To make more progress here, https://github.com/lbryio/lbry-desktop/issues/7663 remove calls and code that call list_blocked and list_filtered on startup.

  • Remove api calls (on startup)
  • Remove blocking reducer/actions/selectors
  • Remove unnecessary inputs to "banstate" which also processes comment moderation which we're keeping

jessopb avatar Aug 30 '22 15:08 jessopb

{
  "lbry://THEBLOCKEDTHING": {
    "error": {
      "censor": {
        "address": "bHkpV3HZBTcBNNqQ6ZgH3jZChBLwEa4Zty",
        "amount": "0.1",
        "canonical_url": "lbry://@LBRY-DMCA#d",
        "claim_id": "dd687b357950f6f271999971f43c785e8067c3a9",
        "claim_op": "create",
        "confirmations": 485176,
        "has_signing_key": false,
        "height": 718715,
        "meta": {
          "activation_height": 718715,
          "claims_in_channel": 340,
          "creation_height": 718715,
          "creation_timestamp": 1582124266,
          "effective_amount": "0.1",
          "expiration_height": 2821115,
          "is_controlling": true,
          "reposted": 1,
          "support_amount": "0.0",
          "take_over_height": 718715
        },
        "name": "@LBRY-DMCA",
        "normalized_name": "@lbry-dmca",
        "nout": 0,
        "permanent_url": "lbry://@LBRY-DMCA#dd687b357950f6f271999971f43c785e8067c3a9",
        "short_url": "lbry://@LBRY-DMCA#d",
        "timestamp": 1582124266,
        "txid": "1b3278a9a37186c6390f9e28aae5ec80d71726b7134c0219c5bc6ec6382fc268",
        "type": "claim",
        "value": {
          "public_key": "3056301006072a8648ce3d020106052b8104000a0342000478ceb85de1da54bddafa809f045023d9c1347fd06ea1d9cbceadddb848e2c5d5855946a0eeed8a0739ea960c67048669dbc2c481ae8a67dd316e772fc778f42e",
          "public_key_id": "bShcpKQuV9PJTqeGEfkRXEhvnYBuEmWR9o"
        },
        "value_type": "channel"
      },
      "name": "BLOCKED",
      "text": "Resolve of 'lbry://THEBLOCKEDTHING' was censored by channel with claim id 'dd687b357950f6f271999971f43c785e8067c3a9' [FOR SOME REASON]"
    }
  }
}

Latest version's text field includes some text from the blocklist publisher about the reason for the block. It would be good to include this text field (for now). Maybe include a space for a 'message' below the app's existing text.

jessopb avatar Aug 30 '22 16:08 jessopb

Is it cause we moving away from hardcoded list to HUB side blocklist?

kodxana avatar Sep 10 '22 10:09 kodxana