lbry-desktop icon indicating copy to clipboard operation
lbry-desktop copied to clipboard

Swap comment servers without going to settings page #7365

Open ByronEricPerez opened this issue 1 year ago • 7 comments

Fixes

Issue Number: https://github.com/lbryio/lbry-desktop/issues/7365

What is the current behavior?

What is the new behavior?

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting)
  • [ ] Refactoring (no functional changes)
  • [ ] Documentation changes
  • [ ] Other - Please describe:

Please check all that apply to this PR using "x":

  • [x] I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • [ ] I added a line describing my change to CHANGELOG.md
  • [x] I have checked that this PR does not introduce a breaking change
  • [ ] This PR introduces breaking changes and I have provided a detailed explanation below

ByronEricPerez avatar Aug 09 '22 18:08 ByronEricPerez

Good progress. Besides fixing styling, this should be at the top next to the refresh button.

The refresh button reloads all comments. The server selector changes the server for all comments.

Below, the comment field adds one comment.

Also, don't forget to make the selector only show up when the number of servers is > 1.

jessopb avatar Aug 11 '22 21:08 jessopb

@ByronEricPerez What do you think if we could have option in app to integrate using multiple comments servers into single feed. Aka at the same time user could see Odysee comments and also other comments server, or user can decide to limit to selected comments servers or just use single one.

kodxana avatar Aug 15 '22 15:08 kodxana

Hi @jessopb how are you, I have already corrected the location, in addition to the fact that it only shows if there are 2 or more commentServer, I just need to add that it shows the comments. And finally some css.

Hi @kodxana , I think the idea is good, it would also be more practical to have the option of being able to show them all in one.

image image

ByronEricPerez avatar Aug 22 '22 12:08 ByronEricPerez

Hi @jessopb , I'm having trouble seeing the comments on all the videos. The btn moved it to the correct component, it already synchronizes, I need to align it a little more. What do you think?

image

Although I comment I get an error asking me to restart, but I have that comment in my history. I also don't see comments on any video. This error started appearing yesterday.

ByronEricPerez avatar Aug 26 '22 19:08 ByronEricPerez

Fixed why it didn't show comments , the error was in index.js

image

ByronEricPerez avatar Aug 26 '22 20:08 ByronEricPerez

Put the refresh button last, and it's a bit too wide, I think.

jessopb avatar Aug 30 '22 17:08 jessopb

@kodxana would you like to test this branch?

jessopb avatar Sep 05 '22 16:09 jessopb