block-explorer icon indicating copy to clipboard operation
block-explorer copied to clipboard

Published 20 hours ago • verified publisher icon lbryio

# of confirmations not calculated correctly

Open tzarebczan opened this issue 6 years ago • 5 comments

It shows 1 confirmation on block and transaction pages.

tzarebczan avatar Feb 25 '19 01:02 tzarebczan

@akinwale / @nikooo777 you think you'd be able to take a look at this one soon? Community members are noticing it as well.

tzarebczan avatar Mar 25 '19 13:03 tzarebczan

So we no longer keep old transactions that are not included in the leading chain. They are cleared. So technically we only have to take current height or max block height and subtract the height of the block in question. I have this in my @tzarebczan if they cannot get to it. I should have the ppv completed tonight. So I can probably make this one the next highest priority.

tiger5226 avatar Mar 25 '19 21:03 tiger5226

Looks like we had a fix, which worked for some, but if you look at https://explorer.lbry.com/address/bSSfLmehtc3PsDoj1ZDNmYkTbrNiTPj2CW the confirmations are not shown correctly on the top blocks.

tzarebczan avatar Jun 03 '19 20:06 tzarebczan

Also the block page does show the right confirmation. Its just this list apparently.

tiger5226 avatar Jun 04 '19 02:06 tiger5226

The old fix from https://github.com/lbryio/block-explorer/commit/667097f35d81e034b3130a5032d8f05461677b10#diff-84d5d8e3196d5767f5a47b5871946dddR598 can be adapted for this.

Essentially, we just need to obtain the max block height and then subtract the height of the corresponding transaction from the max height.

akinwale avatar Jun 05 '19 15:06 akinwale