Logan Magee

Results 62 comments of Logan Magee

Round 2. Should *actually* be fixed now.

Great. I'll go ahead and add a confirmation dialog for uninstalls, then we can test it along with updates and call it good for merging. > My only other concern...

Added the uninstall confirmation dialog. Shouldn't need much testing. Note it's not tied to the toggle and is instead always enabled in privileged mode by design.

> Great. Dialogue is shown, buttons are working as expected, switch is off by default, everything ok. Cool. All that's left is testing updates then (which I'm 99% sure will...

I'll let you know when I bump the version. I'm sure enough that automatic updates will be fine, but the UI code around manual updates is a bit more complicated...

Sweet! Thank you so much for testing this.

Reopening due to https://github.com/accrescent/accrescent/commit/5c73758e10552987509359220ae74530946264aa

> how can I execute an upsert using DAO api? https://github.com/JetBrains/Exposed/wiki/FAQ#q-is-upsert-supported

The reason I suggest it in bundletool is that setting the minSdk in the app seems more like a workaround for bundletool's default behavior than a "proper" solution since the...