QuantLib icon indicating copy to clipboard operation
QuantLib copied to clipboard

Move clang-analyzer-optin.cplusplus.VirtualCall suppressions to comments

Open sweemer opened this issue 3 years ago • 1 comments

Ideally there should be no need to suppress this check, because no virtual functions should be called in any constructors or destructors as a general design rule. However, user code probably depends on the current behavior, so I have left the current behavior as is and have simply moved the suppression to comments so that at least any new code can be flagged before it is released.

sweemer avatar Sep 05 '22 22:09 sweemer

Coverage Status

Coverage: 71.867% (-0.007%) from 71.875% when pulling 115fd75c43b680f548bd72fad1921d673926dbf4 on sweemer:virtual-call into 94b218eadbf8ba42ec1906fe4f3606c778f74639 on lballabio:master.

coveralls avatar Sep 05 '22 23:09 coveralls

Let me sit on this a bit — I'll check some of the issues.

lballabio avatar Oct 02 '22 19:10 lballabio

I removed a few of the calls where it made sense. Thanks!

lballabio avatar Feb 08 '23 19:02 lballabio