lballabio
Target netstandard2.0
Many .NET applications still run on .NET Framework and cannot consume the net60 build. I propose we also target netstandard2.0 which would require a minimum .NET Framework version of net472. I don't think it's worth targeting lower than that.
I added the net472 target for the example projects, but strictly that's not required. Let me know if I should revert that.
Do you have a manual process to prepare the NuGet package?
I'm using the workflow at https://github.com/lballabio/quantlib-wheels/blob/master/.github/workflows/dotnet.yml — it actually replaces the .csproj file, so that's where you should try and modify the build.
This PR was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@igitur The 1.33 nupkg should have netstandard2.0 enabled, but I'm not sure that the embedded C++ DLL is in the right place for the package to work (I found very little documentation on that). May you check if that's the case? Thanks!
Sure, I'll check it out.
Sorry, when I saw the release note for 1.33 I realised I still had this on my to-do list. Life is whack-a-mole here at this stage. :-D
This PR was automatically marked as stale because it has been open 60 days with no activity. Remove stale label or comment, or this will be closed in two weeks.
This PR was automatically closed because it has been stalled for two weeks with no further activity.