scopedQuerySelectorShim icon indicating copy to clipboard operation
scopedQuerySelectorShim copied to clipboard

Published 20 hours ago • verified publisher icon lazd

retain copyright notice

Open jpdevries opened this issue 10 years ago • 4 comments

Correct me if I'm wrong but it seems like scopedQuerySelectorShim.js disobeys it's own LICENSE. The README says to simply include the scopedQuerySelectorShim.js file, but it that is all you do you disobey the LICENSE.

jpdevries avatar Jun 26 '15 18:06 jpdevries

Yeah, scopedQuerySelectorShim.js could benefit from a license header.

I'd expect something like this, however, that calls out what license is being used:

/* scopeQuerySelectorShim.js
 *
 * Copyright (C) 2015 Larry Davis
 * All rights reserved.
 *
 * This software may be modified and distributed under the terms
 * of the BSD license.  See the LICENSE file for details.
 */

lazd avatar Jun 26 '15 19:06 lazd

What do you think about making use of the Grunt workflow to build an unminified and minified version of the source file with said header included? If that sounds like something you might be interested in I'd be happy to submit a PR

jpdevries avatar Jun 27 '15 15:06 jpdevries

Sounds good, as long as the version you get when you install with Bower still has the header!

lazd avatar Jun 27 '15 16:06 lazd

ya, i think we could manage that using exportOverrides. I'll see what I can do

jpdevries avatar Jun 27 '15 16:06 jpdevries