iNoBounce icon indicating copy to clipboard operation
iNoBounce copied to clipboard

Breaks time scrubbing on video tag

Open headsuptechnologies opened this issue 9 years ago • 4 comments

Time scrubbing/seeking on the built in video controls will not get the touchmove event. Work around is to set the overflow scrolling CSS properties on the video tag's parent, but this still affects the performance of the scrubbing.

headsuptechnologies avatar Nov 17 '15 22:11 headsuptechnologies

Very interesting. Maybe we can add an exception when touchstart happens inside of a video element... Can you create a fiddle that reproduces the error so I can poke at it?

On Tuesday, November 17, 2015, Jon Jensen [email protected] wrote:

Time scrubbing/seeking on the built in video controls will not get the touchmove event. Work around is to set the overflow scrolling CSS properties on the video tag's parent, but this still affects the performance of the scrubbing.

— Reply to this email directly or view it on GitHub https://github.com/lazd/iNoBounce/issues/19.

lazd avatar Nov 17 '15 23:11 lazd

@headsuptechnologies perhaps we need an exception for the <video> element the same way that we have for input[type="range"] (https://github.com/lazd/iNoBounce/pull/29). Would that fix the issue?

lazd avatar Sep 22 '16 16:09 lazd

I faced same problem of video and audio tag on iOS safari10. And I could fix the issue by the same way #29

if ((el.nodeName === 'INPUT' && el.getAttribute('type') === 'range') ||
    el.nodeName === 'VIDEO' || el.nodeName === 'AUDIO') {
    return;
}

hideyuki avatar Oct 18 '16 17:10 hideyuki

@hideyuki looks good, please send a pull request for this!

lazd avatar Oct 21 '16 16:10 lazd