gulp-karma icon indicating copy to clipboard operation
gulp-karma copied to clipboard

Published 20 hours ago • verified publisher icon lazd

Add options.dieOnError

Open jimthedev opened this issue 10 years ago • 5 comments

Fixes #23 by adding an option to not throw a plugin error.

jimthedev avatar Mar 20 '14 15:03 jimthedev

+1 any reason this hasn't been merged yet?

akreitals avatar Jul 16 '14 22:07 akreitals

+1 this makes a lot of sense. However, gulp-karma will be refactored into more of a helper soon. See https://github.com/lazd/gulp-karma/issues/21#issuecomment-40786028 for details.

lazd avatar Jul 19 '14 20:07 lazd

@jimthedev and @akreitals, one question: Have you tried adding an error listener on the stream? That should stop it from dying.

lazd avatar Jul 23 '14 14:07 lazd

@lazd I think I did, and it would catch the error but still end the stream in certain cases where there was a parse error. With this said, it has been long time since I looked at this so I'm not 100% sure. I don't actually have the branch which used gulp-karma on my project anymore. We're currently using grunt still.

jimthedev avatar Jul 23 '14 14:07 jimthedev

@lazd Yeah sure did, but with no success unfortunately. In the interim I have simply implemented the dieOnError option while we wait for the Karma issue to be resolved.

akreitals avatar Jul 23 '14 22:07 akreitals