Lazar Ljubenović

Have you thought about migrating to TS in source code? Writing declaration files is boring, error-prone, and needs manual updates every time source code changes. Rewriting the code into TypeScript...

A year later I still believe this module would greatly benefit from being completely rewritten in TypeScript. It would mostly be adding types to existing code, occasionally refactoring tiny bits...

I've been fiddling around with a TypeScript on and off for some time now. The main issue for me seems to be abusing the CommonJS exports structure. I have troubles...

None of the parser I've encountered are strict with `stringify(parse(content)) === content` in terms of trivia (whitespace, comments). Of course, it's not like I'm some parser guru, so that doesn't...

> This is a known limitation with esbuild. Tree shaking is supported with `import * as x` but not when `x` is then re-exported and re-imported. Imports are only tracked...

What's really missing is a warning in the docs not to nest CVAs and the official guide for a [reusable form group](https://stackoverflow.com/a/46025197/2131286). Even better, a runtime warning. It just doesn't...

Isn't avoiding giving the name 90% of the choice to use `|>` though? This would make parsing harder (and I assume slower), and would be one more thing to teach....

I'm not sure I understand the semantics for the proposed `before` method. Before what? Also its reliance on `this` would make it impossible or difficult to use the fat arrow...

> Alternatively it would be useful to have some way to use an external lexer. E.g. pass in an iterable of some object type that includes a lexical class, location...

Since `ng-bootstrap` calls `preventDefault` on the `keydown` event (see below), https://github.com/ng-bootstrap/ng-bootstrap/blob/b5d5febde5691286211dd2401c2cb5334db0851f/src/typeahead/typeahead.ts#L293-L294 you can check in your own handler for the `defaultPrevented` flag before you trigger your search function.