Luke Zappia

Results 196 comments of Luke Zappia

I think the remaining error here is because of the **{rhdf5}** problem. I'm not really sure what to do about that.

> So maybe one question is: if something like `write_h5ad_categorical` fails, should we: > > * throw an error > * generate a warning but at least remove the `categorical`...

> However, in any situation where a write fails, it would probably be best to remove the field and show a warning. WDYT? (No need to already implement this, let's...

@rcannood I think this should work now with the current devel version of **{rhdf5}** if you want to take a look at it. I suspect the CI will fail though.

Thanks for merging! We might want to bump the **{rhdf5}** version in `DESCRIPTION` to make it clearer what is required. I think I didn't do that already to avoid people...

The test/example stuff I would like to do but requires a working `Seurat` converter. I think maybe it's easier to merge this first? The vignette would be nice but can...

- Why would a user ever need to create a `HDF5AnnData`? The `read`/`write` functions handle going to/from files and I can't think of a reason to interact with one of...

Yes, I think so. I'll try to work on it, assuming I can work out how to implement `as()` properly.

Ok, so using `as()` probably won't work for us because there is no way to provide additional arguments (which I think we need for things like setting which assay should...

Yeah, that could work. What about the reverse direction?