Guillaume Maudoux
Guillaume Maudoux
@jeking3 Resolved conflicts with https://github.com/apache/thrift/pull/3049, and fixed the logic as per my comment above. May I ask you to have a second look at this PR ?
@jherland It is a bit tricky to avoid a new flag. One option I ditched was to use the most recent passed on the command line, as in: ``` fawltydeps...
@fgaz All right, but where then ?
The best place I can think of right now is `nix build --derivation`. But one may prefer `nix instantiate`. This is a trivial change, but how to get an agreement...
Should it be named `nix derivation add-to-store` or `nix derivation store` ? These would be more explicit that it is going to write the derivation to the store, right ?...
@tomberek Thanks for making a decision. I updated the PR to reflect the naming choice. It seems there may have been a second point, but you did not fill it....
Oh, just rebased, that was probably the second point.
I have reworked output. It now uses a list instead of a set. Documentation and tests updated accordingly. (also rebased, because I thought that may fix running tests in meson,...
[edit] I do not think this message was constructive or useful [/edit]
Yes, sure, have a look at https://github.com/layus/pinocchio/commits/clang-tidy-mwe/. I committed a reproducer script called repro.sh. my repro uses pinocchio (the forked repo), and libstdc++11 from ubuntu 22.04, downloaded from here https://www.ubuntuupdates.org/package/core/jammy/main/updates/libstdc%2B%2B-11-dev