layup-list icon indicating copy to clipboard operation
layup-list copied to clipboard

Expectation of 10 medians on ORC page incorrect

Open zack-overflow opened this issue 2 years ago • 0 comments

https://github.com/layuplist/layup-list/blob/83073ffa18cc5dd2ea8b7137ce361e546a728ec4/apps/spider/tasks.py#L34

This line asserts that crawling the medians from the ORC should return results from the last ten terms. Looking at the medians page from March in the Wayback machine, the previous ten terms worth of medians were listed.

Looking at the current page, however, there are only eight medians listed, so the check is throwing an error based on a false negative (it is written to expect the median crawling function to return ten terms, there are only eight this term). I don't know if this reduction in the number of terms with medians available is unique to summer, a permanent change going forward, or specific to 22X. Either way,

  1. There should be some conditionals to guard against times when fewer than ten medians are listed.
  2. I wonder if this is causing issues in prod. Is there logging set up?

zack-overflow avatar Jul 28 '22 09:07 zack-overflow