laytan
[Feature request]: Snacks picker integration
It would be nice to have an integration with snacks picker since it is becoming new standard.
I have created a plugin and there is already an implementation - ecolog.nvim. You can take a look.
ecolog.nvim can be used as a nearly drop-in replacement for cloak.nvim, it provides all-in-one toolkit to work with environment variables and .env files. There is also a comparisons table
Slightly off topic:
It's kind of weird opening two issues and answering one within 7 minutes and ending both with a: "My plugin does this already + and it's a drop-in".
Though who am I to judge. While you're at it I think adding any metric of code size would do well in said comparisons table.
Personally what I really like about cloak.nvim is the very small code size, which leads to almost trivial reviews before using it.
I wouldn't want to add a plugin which is used by a few hundred people and tell it in detail where and how my secrets are located.
That being said both issues are very valid and #25 could be considered a big security risk. If I ever need more than some bare bones cloaking, I will probably check out your project.
Side note:
Thanks for pointing it out. Your point is valid regarding that cloak.nvim provides more flexible approach (works with any file type) and has less code size. I will add code size metric to comparisons table.
Regarding actual topic:
That's how exactly it was implemented in my plugin it may be useful when making a pull request https://github.com/philosofonusus/ecolog.nvim/blob/main/lua/ecolog/shelter/integrations/snacks.lua
I'm not gonna leave a feature request open that is authored by somebody that made their own plugin. You do not need this feature in cloak, because you have your own plugin that implements it, so that's not a valid feature request.
@laytan I believe that this issue is valid, sinc it correlates to the main logic with telescope previewer integration and similar feature request opened with fzf-lua that you have tagged as an enhancement. Does it mean that it is not going to be implemented at all? What if somebody else opens this issue without specifying a solution from a separate plugin, will you close it as a duplicate? I personally may not need it, but there are else people that may need it, since snacks picker is becoming a new standard in LazyVim distribution. What exactly qualifies this issue as not valid?
If you do believe that this is not going to be implemented tag this issue as wontfix, so that other people in future will understand that similar feature requests are not going to be valid.
If a genuine user requests it, it's a fine request. You don't need it because you use a plugin which already has it right? It's weird to open feature requests to projects you don't have any intent to use.
Yes, you are right, it is weird. However, the context of a feature request doesn't disqualify it and make it invalid
I'm using cloak.nvim in yaml files. This makes it legitimate feature request according to your explanation. If that's not going to be implemented either mark it accordingly or reopen this