uBlockOrigin-HUGE-AI-Blocklist icon indicating copy to clipboard operation
uBlockOrigin-HUGE-AI-Blocklist copied to clipboard

Update list_uBlacklist.txt with better Amazon URL catching

Open xor50 opened this issue 11 months ago • 3 comments

  1. catch all Amazon TLDs
  2. because Amazon URLs are weird you can actually have whatever text you want before the dp/[code] so we need to catch all of those. The dp/[code] is the only part of the URL that defines the product.

xor50 avatar Mar 18 '24 20:03 xor50

Weirdly, this isn't working for me.

laylavish avatar Mar 19 '24 12:03 laylavish

I haven't tested the change in the filter, I just assume * would work "normally" as wild card in those filter lists. Maybe wild cards work differently?

But you can 100% check the URLs for yourself. Let's use something harmless, maybe some toy bear:

  1. https://www.amazon.com/this_is_a_toybear/dp/B0BYSN5H82/
  2. https://www.amazon.de/somethingelseherebutthesameproduct/dp/B0BYSN5H82/

Note that it's the exact same but the difference in TLD and the part before /dp/[code]

xor50 avatar Mar 19 '24 12:03 xor50

So, uBlacklist does not support wildcard match patterns for top level domains, but fortunately you can use regex. This one I made seems to work well.

 /amazon.+\/.+\/dp\/B0CVTYD34P/

You can use this template for these changes (replace B0CVTYD34P with each product name you want matched), then I'll merge (or I can just do a good ol'e commit).

laylavish avatar Mar 20 '24 07:03 laylavish

nevermind, i just committed my regex version in main, so this should catch all amazon urls

laylavish avatar Mar 21 '24 03:03 laylavish