TLDExtract

TLDExtract copied to clipboard

TLDExtract not properly parsing hostname

1

I'm running some domain names through `TLDExtract` and came across a domain not being properly parsed. The URL is called `blogspot.com` ``` $url = 'blogspot.com'; $domain = tld_extract($url); var_dump($domain); Returns:...

leem32

Some reading for improve or fix in case it’s needed : https://en.wikipedia.org/wiki/Domain_name introduce https://tools.ietf.org/html/rfc1034 https://tools.ietf.org/html/rfc1035 domain name are URL https://en.wikipedia.org/wiki/Url introduce https://url.spec.whatwg.org/ should permit to close #45

HumanG33k

TLD for domain test.ru is not recognized

2

I have tested with hundred of domains, but for the domain test.ru i get the following result: ``` Result {#1711 ▼ -subdomain: null -hostname: "test.ru" -suffix: null } ```

LinkingYou

``` $extract = new Extract(); $result = $extract->parse("test@[email protected]")->isValidDomain(); ``` This results in `true`, when it should be `false` ("@" is not allowed in domain names)

skeets23

Parser bug when subdomain has "-"

1

The parser fails for the following: ``` // If the subdomain has "-" $url = 'https://s3-ap-southeast-2.amazonaws.com/blabla/blabla/wp-content/uploads/media/2019/03/16860571424_31c94205de_b.jpg'; // Extract domain parts $extract = new \LayerShifter\TLDExtract\Extract(); $domainParser = $extract->parse($url); parse_url($url, PHP_URL_HOST); //...

NizarBlond

Hello There is a bug in the libary where it mishandles the backslash character For example https://1337.karimrahal.com\.bla.com would give bla.com as the registered domain where as the browser would lead...

ohm-s

bug(Parser): incorrect result of getRegistrableDomain()

3

This doesn't seem to work for any blogspot subdomain.. test.blogspot.com gives as registrable domain: test.blogspot.com test.github.com gives as registrable domain: github.com I don't understand how it would work that way?

atypicalprogrammer

Support PHP 5.4.0 for version 0.2.0

1

Hello, can you please change the `guzzlehttp/guzzle` package in your composer version 0.2.0? `guzzlehttp/guzzle` version 6.* doesn't support PHP 5.4.0. But version 5.* does. So can you change it to...

ivankristianto