wasm-filters icon indicating copy to clipboard operation
wasm-filters copied to clipboard

Published 20 hours ago • verified publisher icon layer5io

[Refactor] Eliminate warnings in Rust code

Open felixfaisal opened this issue 3 years ago • 7 comments

Description Currently, upon building any of the filters you get rust compilation warnings. We can eliminate these warnings and follow best practices of Rust.

Expected Behavior Code compiles without any warnings

Screenshots Image

To Reproduce Steps to reproduce the behavior:

  • Compile any of the filters

felixfaisal avatar Jan 05 '22 16:01 felixfaisal

Ouch. Good find. Yes. Would you like to take this on, @felixfaisal?

leecalcote avatar Jan 17 '22 20:01 leecalcote

I'd like to take this on @leecalcote :D

felixfaisal avatar Jan 19 '22 05:01 felixfaisal

@felixfaisal, excellent. 😄

leecalcote avatar Jan 23 '22 20:01 leecalcote

Is anyone working on this or may I?

Azanul avatar Feb 15 '23 11:02 Azanul

@Azanul I am but I'm still waiting on my PR to be accepted and merged.

acald-creator avatar Feb 15 '23 13:02 acald-creator

Hello @acald-creator @felixfaisal Didn't any linked PRs to this issue, would like to review the PR ( if already solved ) or would like to solve it.

horizenight avatar Dec 19 '23 10:12 horizenight

Hey @horizenight I think you can take it up if the following PR does not solve it already - https://github.com/layer5io/wasm-filters/pull/49 but would be great if you double check it with @acald-creator
CC: @leecalcote

felixfaisal avatar Jan 09 '24 06:01 felixfaisal