sistent
sistent copied to clipboard
Update publish modal schema
Notes for Reviewers
This PR fixes #
This PR adds missing parameter in publish modal RJSF schema which tell RJSF to decode input data in URI encoded format and show data in input field in decoded format
Signed commits
- [ ] Yes, I signed my commits.
From today’s call, there was some confusion about whether we should accept this change or not. I think yes, we should, because Uzair's proposal was to migrate these schemas to the schemas repo, which wasn't directly related to fixing the issue. My proposal was to address the issue first. Previously, we had these schemas in the schemas repo, but they were migrated to Sistent. Moving them back to the schemas repo now would require more effort than is currently necessary.
For now (right now) I'm focusing on fixing issue not creating extra work which I'm not sure should be a priority, I understand it is nice to have these schemas in schemas repo however I'm not sure if we should put this on priority right now, if we should do then let me know
@MUzairS15 @aabidsofi19 thoughts?
i think the publish schema should be derived from the schema for input of the publish endpoint . to remove the redundancy of redefining the same properties . for the presentation we should use a separate uiSchema ( that defines ui like the widget to use, grid size etc not the data structure )
// @leecalcote @Yashsharma1911 @MUzairS15
A relevant discussion - https://github.com/meshery/meshkit/pull/584#issuecomment-2322800552
i think the publish schema should be derived from the schema for input of the publish endpoint . to remove the redundancy of redefining the same properties . for the presentation we should use a separate uiSchema ( that defines ui like the widget to use, grid size etc not the data structure )
// @leecalcote @Yashsharma1911 @MUzairS15
This makes much more sense, we can update the capability of uiSchema to support this, and one part is to move them in single place, it does make sense for me if these schemas get bundled in schema repo npm package.
There is issue with prettier, lemme fix it
@Yashsharma1911 are we reordering fields, too?
I need approval to merge this PR, if looks good would be nice
@Yashsharma1911 are we reordering fields, too?
Ops I missed this, lemme fix it quick
Thankyou for approving and merging PR @vishalvivekm