sistent icon indicating copy to clipboard operation
sistent copied to clipboard

Published 20 hours ago • verified publisher icon layer5io

Add share modal

Open Yashsharma1911 opened this issue 1 year ago • 5 comments

Notes for Reviewers

This PR fixes #

This PR adds two reusable components

  • [X] User search field
  • [x] Share modal which uses user search field

Signed commits

  • [x] Yes, I signed my commits.

Yashsharma1911 avatar Jul 11 '24 16:07 Yashsharma1911

Share modal is also will push it quickly after testing

Yashsharma1911 avatar Jul 11 '24 16:07 Yashsharma1911

Testing in cloud

Yashsharma1911 avatar Jul 11 '24 23:07 Yashsharma1911

Checking in again. No new commits. Is @sudhanshutech feedback to be incorporated, @Yashsharma1911?

leecalcote avatar Jul 19 '24 11:07 leecalcote

Yes and I hold off on this as this is a feature and we got bugs in the catalog in GitHub action, so I prioritized them

I already mentioned in cloud PR I'll be merging them by end of this week

Yashsharma1911 avatar Jul 19 '24 11:07 Yashsharma1911

@Yashsharma1911 circling back...

leecalcote avatar Aug 02 '24 13:08 leecalcote