sistent icon indicating copy to clipboard operation
sistent copied to clipboard

Icons set to filled by default

Open leecalcote opened this issue 1 year ago • 8 comments

Current Behavior

Related to https://github.com/layer5io/sistent/issues/654...

Screenshot 2024-06-25 at 4 43 07 PM

Contributor Guide

leecalcote avatar Jun 25 '24 21:06 leecalcote

Hi, I would like to take this issue. Can you assign it to me? I have already cloned the repo, and now I am trying to locate that icon in the code.

heysujal avatar Sep 10 '24 18:09 heysujal

@heysujal sounds great!

leecalcote avatar Sep 11 '24 00:09 leecalcote

I have done the local setup of project and also made changes in sistent component , but I am not able to find where this is being used in Layer5 site

heysujal avatar Oct 04 '24 08:10 heysujal

I have tried to make changes in sistent, then build it. After doing this, I installed it in Layer5 and tried to use it. For some reason, it is not able to pickup the changes I have made to add the fill property. These are the changes I have made EditIcon.tsx image

404.js in Layer5. (Just for testing out)

image

Output

image

heysujal avatar Oct 04 '24 16:10 heysujal

@heysujal, apologies, I've not seen you're messages until now. I'm tagging others, who can assist, though. @nebula-aac @sudhanshutech @SAHU-01 @hargunkaur286 @amitamrutiya

leecalcote avatar Oct 11 '24 16:10 leecalcote

@leecalcote @sudhanshutech Hey is this issue still open :)

ShivanshCharak avatar Aug 20 '25 18:08 ShivanshCharak

@vr-varad, please triage.

leecalcote avatar Aug 20 '25 19:08 leecalcote

Hey @ShivanshCharak it is open for everyone. But keep in mind, the issue is about the Icons being filled and themed at the same time.

vr-varad avatar Aug 21 '25 11:08 vr-varad