sistent icon indicating copy to clipboard operation
sistent copied to clipboard

Consolidate separate markdown renderers

Open dragon-slayer875 opened this issue 1 year ago β€’ 4 comments

Current Behavior

Currently, we use two Markdown renderers:

  • RenderMarkdown
  • RenderMarkdownTooltip

This was done at the time to avoid a change in functionality without reviewer availability. But it has been reviewed since then, and now it is desired to be consolidated.

Expected Behavior

They can be consolidated into one by passing props instead, to make a single component.

Screenshots/Logs

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Resources

dragon-slayer875 avatar May 20 '24 06:05 dragon-slayer875

// @sudhanshutech

dragon-slayer875 avatar May 20 '24 06:05 dragon-slayer875

@dragon-slayer875 , I would like to work on these issue.

senthil-athiban avatar Jul 30 '24 18:07 senthil-athiban

@senthil-athiban any updates here?

dragon-slayer875 avatar Aug 12 '24 14:08 dragon-slayer875

sorry for the delay @dragon-slayer875 as I was working on other area. Made changes here PR

senthil-athiban avatar Aug 12 '24 14:08 senthil-athiban

Issue and PR abandoned.

leecalcote avatar Oct 04 '24 13:10 leecalcote