sistent icon indicating copy to clipboard operation
sistent copied to clipboard

[CI] Redundant `npm install` step in release workflow?

Open leecalcote opened this issue 1 year ago β€’ 2 comments

Current Behavior

The current release workflow has two steps performing npm install. Is this necessary or is it a redundant step that might be eliminated?

https://github.com/layer5io/sistent/blob/f0b95c49ee7ccaa62789fd6aa7e49158d83fe731/.github/workflows/release.yml#L22


Contributor Guides and Resources

leecalcote avatar Feb 13 '24 12:02 leecalcote

It was necessary when I had the error with husky, but not sure now after changing it. I'll review again if this steps is still needed or not.

nebula-aac avatar Feb 13 '24 13:02 nebula-aac

Ok, gotcha.

On Tue, Feb 13, 2024 at 7:23β€―AM Antonette Caldwell @.***> wrote:

It was necessary when I had the error with husky, but not sure now after changing it. I'll review again if this steps is still needed or not.

β€” Reply to this email directly, view it on GitHub https://github.com/layer5io/sistent/issues/505#issuecomment-1941506658, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZYKEHV7IJGGA65D4DQD2DYTNSLNAVCNFSM6AAAAABDGN62ZWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBRGUYDMNRVHA . You are receiving this because you authored the thread.Message ID: @.***>

leecalcote avatar Feb 14 '24 05:02 leecalcote

I will see if this can fixed

sudhanshutech avatar Aug 31 '24 06:08 sudhanshutech