sistent icon indicating copy to clipboard operation
sistent copied to clipboard

Fix: Add mobile tap support for CustomTooltip

Open M-DEV-1 opened this issue 8 months ago • 2 comments

Notes for Reviewers

This PR fixes #1005

Signed commits

  • [x] Yes, I signed my commits.

M-DEV-1 avatar Apr 30 '25 13:04 M-DEV-1

Sistent#1005

I tested the above changes, and it works for Modal Footer icon, CustomToolTips, InfoToolTips 👍🏼

M-DEV-1 avatar Apr 30 '25 13:04 M-DEV-1

Thank k you, @M-DEV-1

leecalcote avatar May 01 '25 02:05 leecalcote

@M-DEV-1 any updates?

amitamrutiya avatar May 14 '25 09:05 amitamrutiya

Screencast from 2025-05-21 04-04-29.webm

I've used the MUI props enterTouchDelay and leaveTouchDelay to support click on mobile device.

I had tried implementing this with ClickAwayListener but that enable onclick support for both desktop and mobile views, and I couldn't figure out a way to detect mobile devices without implementing something like isTouchDevice or media queries maybe.

@amitamrutiya

M-DEV-1 avatar May 20 '25 22:05 M-DEV-1

I've made the changes @amitamrutiya

M-DEV-1 avatar May 27 '25 07:05 M-DEV-1