meshery-performance-action icon indicating copy to clipboard operation
meshery-performance-action copied to clipboard

Istio Crypto Scheduled Workflow

Open asubedy opened this issue 2 years ago • 11 comments

Description

This PR fixes #

Notes for Reviewers

Signed commits

  • [ ] Yes, I signed my commits.

asubedy avatar Jul 06 '23 11:07 asubedy

@asubedy Can I confirm that this PR ready to be merged?

gyohuangxin avatar Jul 14 '23 02:07 gyohuangxin

No @gyohuangxin it is not cometely ready. It still needs a dynamic component registration feature. It will not be able to create performance profile now. So let's hold on merging a little. Ill let you know when its ready

asubedy avatar Jul 14 '23 02:07 asubedy

@asubedy Left some comments, if you have any doubts feel free to ask here or on Slack channel. Thanks!

gyohuangxin avatar Jul 21 '23 02:07 gyohuangxin

Related to #78 @asubedy Any updates here?

gyohuangxin avatar Aug 07 '23 06:08 gyohuangxin

@gyohuangxin could you please send the httpbin application file that you used file I am using this file but it is showing me some error

# Copyright Istio Authors
#
#   Licensed under the Apache License, Version 2.0 (the "License");
#   you may not use this file except in compliance with the License.
#   You may obtain a copy of the License at
#
#       http://www.apache.org/licenses/LICENSE-2.0
#
#   Unless required by applicable law or agreed to in writing, software
#   distributed under the License is distributed on an "AS IS" BASIS,
#   WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#   See the License for the specific language governing permissions and
#   limitations under the License.

##################################################################################################
# httpbin service
##################################################################################################
apiVersion: v1
kind: ServiceAccount
metadata:
  name: httpbin
---
apiVersion: v1
kind: Service
metadata:
  name: httpbin
  labels:
    app: httpbin
    service: httpbin
spec:
  ports:
  - name: http
    port: 8000
    targetPort: 80
  selector:
    app: httpbin
---
apiVersion: apps/v1
kind: Deployment
metadata:
  name: httpbin
spec:
  replicas: 1
  selector:
    matchLabels:
      app: httpbin
      version: v1
  template:
    metadata:
      labels:
        app: httpbin
        version: v1
    spec:
      serviceAccountName: httpbin
      containers:
      - image: docker.io/kong/httpbin
        imagePullPolicy: IfNotPresent
        name: httpbin
        ports:
        - containerPort: 80
---
apiVersion: networking.istio.io/v1alpha3
kind: Gateway
metadata:
  name: httpbin-gateway
spec:
  # The selector matches the ingress gateway pod labels.
  # If you installed Istio using Helm following the standard documentation, this would be "istio=ingress"
  selector:
    istio: ingressgateway
  servers:
  - port:
      number: 80
      name: http
      protocol: HTTP
    hosts:
    - "httpbin.example.com"
---
apiVersion: networking.istio.io/v1alpha3
kind: VirtualService
metadata:
  name: httpbin
spec:
  hosts:
  - "httpbin.example.com"
  gateways:
  - httpbin-gateway
  http:
  - match:
    - uri:
        prefix: /status
    - uri:
        prefix: /delay
    route:
    - destination:
        port:
          number: 8000
        host: httpbin

asubedy avatar Aug 14 '23 16:08 asubedy

@asubedy I think it comes from the Istio example: https://github.com/istio/istio/blob/master/samples/httpbin/httpbin.yaml, we are also using it. Can you show me the error you met?

gyohuangxin avatar Aug 15 '23 06:08 gyohuangxin

While using GitHub action this is the error I got: image

When I try it on my local system this is the error i get Screenshot 2023-08-14 at 21 04 25

asubedy avatar Aug 16 '23 18:08 asubedy

A quick note that I have added these configuration too on the httpbin application image

as given in this guide

asubedy avatar Aug 16 '23 18:08 asubedy

While using GitHub action this is the error I got: image

When I try it on my local system this is the error i get Screenshot 2023-08-14 at 21 04 25

I'm not sure what happen when you use mesheryctl app onboard to apply this file, can you try kubectl apply -f directly?

gyohuangxin avatar Aug 17 '23 01:08 gyohuangxin

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Oct 15 '23 11:10 stale[bot]

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

stale[bot] avatar Dec 15 '23 05:12 stale[bot]