linkerd-service-mesh-workshop icon indicating copy to clipboard operation
linkerd-service-mesh-workshop copied to clipboard

to fix error in "Slack Notify on Star" Job under GitHub Actions

Open saurabh100ni opened this issue 2 years ago • 12 comments

Description

Under GitHub Actions of this repository "Slack Notify on Star" job is failing for which Slack.yaml is to be Updated.

Fix

To fix this issue, update the code of slack.yaml just by copy/pasting the code from slack.yaml of meshery

saurabh100ni avatar Sep 27 '23 12:09 saurabh100ni

Thanks for opening this issue. A contributor will be by to give feedback soon. In the meantime, please review the Layer5 Contributors' Welcome Guide and sure to join the community Slack.

welcome[bot] avatar Sep 27 '23 12:09 welcome[bot]

@saurabh100ni I want to fix this issue, Please assign it to me.

AdiDecodes avatar Sep 28 '23 08:09 AdiDecodes

You got it @AdiDecodes 😎🚀

saurabh100ni avatar Sep 28 '23 08:09 saurabh100ni

You got it @AdiDecodes 😎🚀

@saurabh100ni ThankYou!, Will work on this soon.

AdiDecodes avatar Sep 28 '23 09:09 AdiDecodes

Hi, @saurabh100ni can I start working on this issue?

hemantmm avatar Oct 03 '23 14:10 hemantmm

@AdiDecodes any Updates ?

saurabh100ni avatar Oct 03 '23 14:10 saurabh100ni

@AdiDecodes any Updates ?

Well not yet, but definately starting from tommorow.

AdiDecodes avatar Oct 03 '23 14:10 AdiDecodes

@AdiDecodes if you are busy with another issue, let's get this one to @hemantmm

saurabh100ni avatar Oct 03 '23 15:10 saurabh100ni

@AdiDecodes if you are busy with another issue, let's get this one to @hemantmm

No I'm not busy, Will fix by today itself

AdiDecodes avatar Oct 03 '23 15:10 AdiDecodes

@saurabh100ni Please check and review the pull request.

AdiDecodes avatar Oct 03 '23 15:10 AdiDecodes

@Mohith234 @sudhanshutech //

saurabh100ni avatar Oct 03 '23 15:10 saurabh100ni

@saurabh100ni updates?

AdiDecodes avatar Oct 05 '23 15:10 AdiDecodes