layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Added Menu Documentation

Open SplinterSword opened this issue 1 month ago β€’ 25 comments

Description

This PR fixes #5952

Notes for Reviewers image image image

Signed commits

  • [x] Yes, I signed my commits.

SplinterSword avatar Oct 29 '25 12:10 SplinterSword

πŸš€ Preview for commit dc7b087477fe2e6e17e5bdb8a877d09f4a1e99cf at: https://69020a273f76e561f896dff0--layer5.netlify.app

l5io avatar Oct 29 '25 12:10 l5io

πŸš€ Preview for commit 07e42b5b5e7770652d2bf4d4fa9da55055d6e042 at: https://6905b1688bc7258e811521e3--layer5.netlify.app

l5io avatar Nov 01 '25 07:11 l5io

Thank you for your contribution! Let’s discuss this during the website call tomorrow (November 3) at 5:30 PM IST | 7:00 AM CT. Please add it as an agenda item to the meeting minutes 😊

Rajesh-Nagarajan-11 avatar Nov 02 '25 13:11 Rajesh-Nagarajan-11

πŸš€ Preview for commit 43ff4d93cda2a2e7fbc47a04d8f8bd19a91bf86f at: https://69098cc21ecbee4a0fcff53f--layer5.netlify.app

l5io avatar Nov 04 '25 05:11 l5io

πŸš€ Preview for commit 43ff4d93cda2a2e7fbc47a04d8f8bd19a91bf86f at: https://69098d2c3c5fb83dce5b8ce4--layer5.netlify.app

l5io avatar Nov 04 '25 05:11 l5io

πŸš€ Preview for commit ee8732c07129d4c978b2a5ea72b588d6e74afb89 at: https://69099d255618fb4f3e5010fe--layer5.netlify.app

l5io avatar Nov 04 '25 06:11 l5io

Y all drop-down of menu's not sticky ? @SplinterSword

Rajesh-Nagarajan-11 avatar Nov 08 '25 17:11 Rajesh-Nagarajan-11

@Rajesh-Nagarajan-11 do you mean that the drop down menu does down with the scroll ??

SplinterSword avatar Nov 08 '25 17:11 SplinterSword

I have just used the code given in the MUI library, so I don't know what is causing this. But I did notice that when the menu is opened in the MUI library, it is just disabling the scroll.

SplinterSword avatar Nov 08 '25 18:11 SplinterSword

If you want I can disable the scroll till the menu is closed ??

SplinterSword avatar Nov 08 '25 18:11 SplinterSword

if the menu dropdown is by default no sticky in the sense , leave here and open a issue for that in sistent

Rajesh-Nagarajan-11 avatar Nov 09 '25 15:11 Rajesh-Nagarajan-11

Okay @Rajesh-Nagarajan-11

SplinterSword avatar Nov 10 '25 11:11 SplinterSword

πŸš€ Preview for commit 88f65ec9718ddeac8de3105521078235fbe016d2 at: https://69158f6f9606eac6c317490f--layer5.netlify.app

l5io avatar Nov 13 '25 07:11 l5io

Please resolve merge conflicts

Rajesh-Nagarajan-11 avatar Nov 16 '25 16:11 Rajesh-Nagarajan-11

πŸš€ Preview for commit 3893d4db4abb304796d3563f03308dae533da73f at: https://691aac8cbb995953c1fb33eb--layer5.netlify.app

l5io avatar Nov 17 '25 05:11 l5io

https://github.com/layer5io/sistent/pull/1185/files With the competition of following PR finally we can merge this, I am testing the sistent changes with other site as well

Namanv0509 avatar Nov 26 '25 20:11 Namanv0509

Okay sure, But it seems the recent changes from the master cause the build to break let me fix this as well.

SplinterSword avatar Nov 27 '25 14:11 SplinterSword

Also @Namanv0509, if any changes are needed, I will be happy to help

SplinterSword avatar Nov 29 '25 03:11 SplinterSword

πŸš€ Preview for commit 68ef6b0f984a2118665993a80a3136fe0e4a9464 at: https://692d306de33d1d784cf89f2d--layer5.netlify.app

l5io avatar Dec 01 '25 06:12 l5io

@SplinterSword Thank you for your contribution! Let's discuss this during the website call today at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would :slightly_smiling_face:

kishore08-07 avatar Dec 01 '25 07:12 kishore08-07

I fixed the scroll issue with this sistent PR

SplinterSword avatar Dec 04 '25 11:12 SplinterSword

I will investigate the disappearing NavBar.

SplinterSword avatar Dec 04 '25 11:12 SplinterSword

@SplinterSword The reason why the navbar disappears is that the modification added in the PR https://github.com/layer5io/sistent/pull/1185 is not here. This PR https://github.com/layer5io/sistent/pull/1185 does solve also the problem with the navbar. I will check later if there are other problems, otherwise I will leave a LGTM.

Fireentity avatar Dec 04 '25 13:12 Fireentity

Ohh okay i didn't realise i fixed two problems at once

SplinterSword avatar Dec 04 '25 13:12 SplinterSword

@SplinterSword Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would πŸ™‚

Fireentity avatar Dec 07 '25 14:12 Fireentity