layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard
Published 3 weeks ago • verified publisher icon layer5io

[newcomers-form] fix: accept Google Drive links in profile picture validation

Open hudazaan opened this issue 2 months ago • 15 comments

Description

This PR fixes #6986

Fixed the profile picture validation to accept Google Drive links. Previously, when users tried to paste Google Drive links as profile pictures, the form showed the error "URL must point to an image file (jpg, jpeg, png, svg, webp or gif)".

Notes for Reviewers

  • This follows the expected behavior of accepting Google Drive links that point to image files
  • No breaking changes to existing functionality
  • Maintains file extension validation for non-Google Drive URLs

Signed commits

  • [x] Yes, I signed my commits.

hudazaan avatar Oct 16 '25 17:10 hudazaan

🚀 Preview for commit 0bc92e9d1d3acfd37b7e55757765f6b767c9e5fc at: https://68f13121a6457b84033b3eb4--layer5.netlify.app

l5io avatar Oct 16 '25 17:10 l5io

This is a very important to work on as I faced this issue through while filling the form. Between, the DCO checks is failing.

FreemanBoss avatar Oct 17 '25 14:10 FreemanBoss

Thankyou for the feedback. I'll simplify the validation and also fix the DCO check issue.

hudazaan avatar Oct 17 '25 14:10 hudazaan

@hudazaan thanks for your contribution , you can check https://github.com/layer5io/layer5/pull/7041/checks?check_run_id=53083532468 to fix the DCO error

Namanv0509 avatar Oct 18 '25 15:10 Namanv0509

🚀 Preview for commit a4dcc1859a85cb56a124cf26864f38f1ede5e444 at: https://68f3b03153e83cd59ef816d1--layer5.netlify.app

l5io avatar Oct 18 '25 15:10 l5io

DCO Failed ⚠️ and @Fireentity Thanks for the review

Rajesh-Nagarajan-11 avatar Oct 24 '25 13:10 Rajesh-Nagarajan-11

Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT Add it as an agenda item to the meeting minutes, if you would 😄

Rajesh-Nagarajan-11 avatar Oct 27 '25 11:10 Rajesh-Nagarajan-11

Thank you for your contribution! Let’s discuss this during the website call tomorrow (November 3) at 5:30 PM IST | 7:00 AM CT. Please add it as an agenda item to the meeting minutes 😊

Rajesh-Nagarajan-11 avatar Nov 02 '25 13:11 Rajesh-Nagarajan-11

🚀 Preview for commit 6a3ff67cb4ae895c6b40df996ba9ec5ead0029ab at: https://6910b1998306858f758ebaee--layer5.netlify.app

l5io avatar Nov 09 '25 15:11 l5io

@hudazaan, you will need to add your sign off on your commit.

leecalcote avatar Dec 01 '25 06:12 leecalcote

@hudazaan To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~3 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin fix/profile-picture-validation

kishore08-07 avatar Dec 01 '25 07:12 kishore08-07

🚀 Preview for commit 61cd707f15c7891182002538294a70430e7ec58f at: https://692d3f50fe3a2e97233a6df2--layer5.netlify.app

l5io avatar Dec 01 '25 07:12 l5io

🚀 Preview for commit aba1488e118c5e57de9c7dccd59ab9ea7097f947 at: https://692d46de73dabd993bafbeba--layer5.netlify.app

l5io avatar Dec 01 '25 07:12 l5io

🚀 Preview for commit c25cc46a31c138f56feb6340d7e42b0f0d127fa1 at: https://692d8639d8a8d80213e2035c--layer5.netlify.app

l5io avatar Dec 01 '25 12:12 l5io

@hudazaan Thank you for your contribution! Let's discuss this during the website call tomorrow at 6:30 PM IST | 8 AM CT Add it as an agenda item to the meeting minutes, if you would 🙂

Fireentity avatar Dec 07 '25 14:12 Fireentity