layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

feat: popup also in kanvas page

Open Fireentity opened this issue 2 months ago • 29 comments

Description

This PR fixes #6444

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

Fireentity avatar Sep 28 '25 15:09 Fireentity

šŸš€ Preview for commit 1e7a0b59c6f67607ffeeb2c1a2d36e28a84559b5 at: https://68d9586ea331b3f124ca6f80--layer5.netlify.app

l5io avatar Sep 28 '25 15:09 l5io

šŸš€ Preview for commit 70adf956d34d09ba2066934cad2521ad279b72eb at: https://68d95c1b6334ac0f6c10076f--layer5.netlify.app

l5io avatar Sep 28 '25 16:09 l5io

Thanks for the feedback @Rajesh-Nagarajan-11 Just to clarify: for the new Kanvas popup, should I also take a new image (different from the Meshery one)? If so, could you point me to where I can get that image, or is the expectation just to update the button and reuse the existing visuals?

Fireentity avatar Sep 28 '25 16:09 Fireentity

šŸš€ Preview for commit 9d5a10965309aadebe561376035b60c342fcc00e at: https://68d989976b775291163e050b--layer5.netlify.app

l5io avatar Sep 28 '25 19:09 l5io

Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

ARYANSHAH1567 avatar Sep 29 '25 06:09 ARYANSHAH1567

@Fireentity Im not sure about that , did you got insights from website meeting ?

Rajesh-Nagarajan-11 avatar Sep 30 '25 16:09 Rajesh-Nagarajan-11

@Rajesh-Nagarajan-11 Yes, I asked, and I followed the suggestion to start a thread on Slack. I’m currently waiting for help.

Fireentity avatar Sep 30 '25 17:09 Fireentity

@Fireentity Could you please share what help you wanted , let me try to help you if possible

Rajesh-Nagarajan-11 avatar Sep 30 '25 17:09 Rajesh-Nagarajan-11

@Rajesh-Nagarajan-11 Could you point me to where I can find the correct image for the new Kanvas popup?

Fireentity avatar Sep 30 '25 17:09 Fireentity

In this page https://layer5.io/cloud-native-management/kanvas/collaborate you can find a animated image

Screenshot_2025-09-30-22-57-34-68_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

If possible you can create a pop with same animated one that will looks perfect

Rajesh-Nagarajan-11 avatar Sep 30 '25 17:09 Rajesh-Nagarajan-11

https://layer5.io/company/brand here you can get some brand template that might helpful to build popup

Rajesh-Nagarajan-11 avatar Sep 30 '25 17:09 Rajesh-Nagarajan-11

šŸš€ Preview for commit de631845cca29c87726edb65a3d5be38f671cec8 at: https://68de962fbaee359c4319e9a8--layer5.netlify.app

l5io avatar Oct 02 '25 15:10 l5io

šŸš€ Preview for commit 537b953bad54d20f7e9680e0f767dae9dddc5303 at: https://68e10f88e7ed381c74dacf78--layer5.netlify.app

l5io avatar Oct 04 '25 12:10 l5io

Screenshot from mobile

image

leecalcote avatar Oct 04 '25 13:10 leecalcote

@leecalcote He implemented in kanvas page

Rajesh-Nagarajan-11 avatar Oct 04 '25 13:10 Rajesh-Nagarajan-11

image image

The image might need an update, so it looks consistent with the pop on landing page , @leecalcote can you help with a new image for kanvas pop up or is the current one good enough.

Namanv0509 avatar Oct 07 '25 21:10 Namanv0509

@Namanv0509 I’m sorry, but I’m not sure I understand what needs to be done. Could you please clarify if there are specific changes needed for the popup I created, or what updates you would like for the image? Do I have to make it look more similar to the homepage popup?

Fireentity avatar Oct 10 '25 16:10 Fireentity

@Namanv0509 Thanks for the feedback. As we discussed in our last call, I'll work on making the style consistent with the homepage popup as soon as possible.

Fireentity avatar Oct 17 '25 15:10 Fireentity

@Fireentity Any updates ? please resolve merge conflicts

Rajesh-Nagarajan-11 avatar Oct 24 '25 13:10 Rajesh-Nagarajan-11

@Rajesh-Nagarajan-11 I just came back to Italy from my leave as announced on Slack. I will resolve it as soon as possible.

Fireentity avatar Oct 25 '25 13:10 Fireentity

šŸš€ Preview for commit d9a772b5649cf02291ed493795dc7351a2fd87ab at: https://68fd2e1fd4cc7239d71a2a42--layer5.netlify.app

l5io avatar Oct 25 '25 20:10 l5io

@Fireentity Any updates ?

Rajesh-Nagarajan-11 avatar Nov 09 '25 11:11 Rajesh-Nagarajan-11

@Rajesh-Nagarajan-11, I reached out to @Namanv0509 because I was unable to locate the popup background in the Layer5 Figma file.

Fireentity avatar Nov 09 '25 21:11 Fireentity

šŸš€ Preview for commit 326ea72aeba78b76ae0b0b93f0fa3411e0ce05d1 at: https://691588f3f813a26dfb215bd3--layer5.netlify.app

l5io avatar Nov 13 '25 07:11 l5io

Merge conflicts resolved.

leecalcote avatar Dec 01 '25 07:12 leecalcote

PR has been resync'ed with master.

leecalcote avatar Dec 01 '25 07:12 leecalcote

šŸš€ Preview for commit 508f65700f09a976d9a0cae5c7966fb5eb67d459 at: https://692d49b4556ae79f7c645e18--layer5.netlify.app

l5io avatar Dec 01 '25 07:12 l5io

image the X icon is missing in pop up and also please fix the eslint error aswell @Fireentity

Rajesh-Nagarajan-11 avatar Dec 01 '25 08:12 Rajesh-Nagarajan-11

šŸš€ Preview for commit 896300cb2d1932597b0399fc779a6086eb3ee146 at: https://69345077c7d983db67ae8a31--layer5.netlify.app

l5io avatar Dec 06 '25 15:12 l5io