layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Added the animated-card component

Open oseniabdulhaleem opened this issue 6 months ago • 35 comments

Description

This PR adds the Animation Card Component #6521

Notes for Reviewers

  • Added the animation card component as provided in the html file

Signed commits

  • [x] Yes, I signed my commits.

A video of how it renders

https://drive.google.com/file/d/1ihandK3cI0CSe6Gp3y6gh3bp5wTu0JH-/view?usp=sharing

oseniabdulhaleem avatar Jun 22 '25 14:06 oseniabdulhaleem

🚀 Preview for commit af797bc3e9cd453ef4306543d3f0533e9dba4b40 at: https://68581aa39e5549db716d36a9--layer5.netlify.app

l5io avatar Jun 22 '25 15:06 l5io

@oseniabdulhaleem Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar Jun 23 '25 11:06 vishalvivekm

🚀 Preview for commit 6d74525d33f625224a7e1972a007b8e8a9872288 at: https://6859539eafb3acd94911ea9e--layer5.netlify.app

l5io avatar Jun 23 '25 13:06 l5io

🚀 Preview for commit f23d3d2ade25df83bde060a59608ff8ab8800761 at: https://68595a17579051c7f5a2a327--layer5.netlify.app

l5io avatar Jun 23 '25 13:06 l5io

@vishalvivekm I just made an update for theme friendliness

oseniabdulhaleem avatar Jun 30 '25 05:06 oseniabdulhaleem

🚀 Preview for commit 842429711ef77f3163a9eec5b75a1212c03acb25 at: https://686224c18482fc4e1631497b--layer5.netlify.app

l5io avatar Jun 30 '25 05:06 l5io

Hi @oseniabdulhaleem , Thank you for your contribution These are the high-level issues I came across, image The animation wave is not there on light mode, please remove everything that says Test, if the change is approved, it will be merged so make sure your code is ready to be merged when raising a PR. image The animation is covering blogs, Please test it thoroughly. The DCO check is also failing.

LibenHailu avatar Jun 30 '25 09:06 LibenHailu

@LibenHailu İ will look into those updates

Thanks for the feedback

oseniabdulhaleem avatar Jun 30 '25 09:06 oseniabdulhaleem

@oseniabdulhaleem Thank you for your contribution! Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

vr-varad avatar Jun 30 '25 11:06 vr-varad

@LibenHailu Thanks for the feedback! I should clarify - the HTML and CSS code didn't include specifications for the wavy animation in light mode, which is why I didn't implement it initially. I can certainly develop something if you'd like.

@vr-varad Unfortunately, I have a work meeting conflict at 7 AM CT today. Would it be possible to discuss this during our next website meeting instead? I can add it to the agenda and continue working on the implementation in the meantime.

oseniabdulhaleem avatar Jun 30 '25 11:06 oseniabdulhaleem

🚀 Preview for commit 69742305cd7af168501dd0535d98928607cbb106 at: https://6863d3cab8966db613e2f207--layer5.netlify.app

l5io avatar Jul 01 '25 12:07 l5io

🚀 Preview for commit 137e6b97aa37831934e02380feffe4d950b9d0e5 at: https://6863e6152de5e5324ff680a5--layer5.netlify.app

l5io avatar Jul 01 '25 13:07 l5io

@vishalvivekm @vr-varad Any update?

oseniabdulhaleem avatar Jul 03 '25 03:07 oseniabdulhaleem

@vishalvivekm @LibenHailu @vr-varad any update?

oseniabdulhaleem avatar Jul 05 '25 15:07 oseniabdulhaleem

If this work is complete, this is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io.

leecalcote avatar Jul 07 '25 03:07 leecalcote

  1. Sign Off your commits
  2. The colors which u are using are not theme colors so would be good if u fix that.

@oseniabdulhaleem

vr-varad avatar Jul 07 '25 13:07 vr-varad

Thanks for the feedback @vr-varad, I will look into it

oseniabdulhaleem avatar Jul 07 '25 13:07 oseniabdulhaleem

🚀 Preview for commit 45412ff63fc6199d080c218e68913807d53bf3ad at: https://686e9e9740d57b1cea961367--layer5.netlify.app

l5io avatar Jul 09 '25 17:07 l5io

Your dco is still failing, we won't accept the pr if the dco is failing. and there are few bugs image the learn more btn becomes invisible when hovered. @oseniabdulhaleem

vr-varad avatar Jul 10 '25 06:07 vr-varad

I will look into that, Thanks for the heads up @vr-varad

oseniabdulhaleem avatar Jul 10 '25 06:07 oseniabdulhaleem

After all the suggested changes make sure u remove the redundant commented code and test-animation-card @oseniabdulhaleem

vr-varad avatar Jul 10 '25 16:07 vr-varad

@vr-varad I just made an update, please check, before i make the final commit.

oseniabdulhaleem avatar Jul 11 '25 18:07 oseniabdulhaleem

🚀 Preview for commit 37d6c415744a8fd2eb7af17759a617f80e87913e at: https://6871574d684f29a96b312c38--layer5.netlify.app

l5io avatar Jul 11 '25 18:07 l5io

🚀 Preview for commit eaabad7947b0391fe28aa963ec7df22092009c14 at: https://687177956c4744e60e29cebe--layer5.netlify.app

l5io avatar Jul 11 '25 20:07 l5io

@vr-varad Done!

oseniabdulhaleem avatar Jul 12 '25 05:07 oseniabdulhaleem

🚀 Preview for commit 60e26e10eed8e4ac12f21def7d510f5afbb61b9c at: https://6871f01a022e4184adfb571d--layer5.netlify.app

l5io avatar Jul 12 '25 05:07 l5io

🚀 Preview for commit 5d1bbc1e477a6b7cf072099709e6846391ffb327 at: https://6872b98a433c6d51f1e1ef67--layer5.netlify.app

l5io avatar Jul 12 '25 19:07 l5io

Hi @oseniabdulhaleem,

To make it easier for others to review the PR, could you please mark all the resolved comments? Most of them are already addressed, but a few still remain. This will help us better understand the current status of the PR. Thank you!

LibenHailu avatar Jul 17 '25 14:07 LibenHailu

🚀 Preview for commit 1c8dbaff6616276f1054afa452209fb909a44f73 at: https://68790de8df2e0342c5ee49b8--layer5.netlify.app

l5io avatar Jul 17 '25 14:07 l5io

@oseniabdulhaleem looks like almost all the pointed reviews are done . As liben said , can you point to unresolved reviews .

Namanv0509 avatar Jul 20 '25 11:07 Namanv0509