layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Fixed Styles and Spacing issues in interpreting-meshery-designs

Open KrishnaShuk opened this issue 6 months ago • 7 comments

Description This PR fixes the Image Rendering and Spacing Issue in interpreting-meshery-designs page [https://layer5.io/learn/learning-paths/mastering-meshery/introduction-to-meshery/meshery/interpreting-meshery-designs ].

This PR fixes #6535

Video for Comparison

https://github.com/user-attachments/assets/7f200faa-1f8d-4a5f-84a6-75ec68856a28

  • [x] Yes, I signed my commits.

KrishnaShuk avatar Jun 13 '25 03:06 KrishnaShuk

🚀 Preview for commit fa69c030c8b5775daf8294dac1e2cdd47ef149d8 at: https://684b9e55c822640948a3b171--layer5.netlify.app

l5io avatar Jun 13 '25 03:06 l5io

🚀 Preview for commit ea8499828dbcdb2f83d1b3b5eba109338e885e30 at: https://684d19a5a49b7228063d0803--layer5.netlify.app

l5io avatar Jun 14 '25 06:06 l5io

hey @vishalvivekm , this PR is ready. You can merge it.

KrishnaShuk avatar Jun 19 '25 05:06 KrishnaShuk

hey @vishalvivekm , this PR is ready. You can merge it.

image Can we center the image i think it can be fixed by removing width="100%" and giving padding, other than that it looks so much better.

LibenHailu avatar Jun 20 '25 10:06 LibenHailu

same for these images as well, u can center them as well image

vr-varad avatar Jun 20 '25 10:06 vr-varad

and make images larger on small screens image

vr-varad avatar Jun 20 '25 10:06 vr-varad

Ok i will make the required changes.

KrishnaShuk avatar Jun 20 '25 13:06 KrishnaShuk

@KrishnaShuk any update?

vr-varad avatar Jun 23 '25 06:06 vr-varad

@vr-varad I am in midst of my college exams. I will make a commit within 2 days.

KrishnaShuk avatar Jun 23 '25 07:06 KrishnaShuk

@vr-varad I have made the required changes.

KrishnaShuk avatar Jun 24 '25 04:06 KrishnaShuk

🚀 Preview for commit bf7676c7e9521a63651bb0c3685ffcb925abe3ec at: https://685a2ac3e037d559c6ff9712--layer5.netlify.app

l5io avatar Jun 24 '25 04:06 l5io

🚀 Preview for commit 84e28706eacb00626c513affc62c70d4c4829bc3 at: https://685a3aa7e037d58be5ff959d--layer5.netlify.app

l5io avatar Jun 24 '25 05:06 l5io

LGMT!

LibenHailu avatar Jun 24 '25 12:06 LibenHailu

@KrishnaShuk LGTM Just One thing add spacing here between image and text. image Screenshot from 2025-06-24 19-23-29

then its good to merge.

vr-varad avatar Jun 24 '25 13:06 vr-varad

@vr-varad Changes done. You can merge it.

KrishnaShuk avatar Jun 26 '25 07:06 KrishnaShuk

🚀 Preview for commit a21245de78bac4789317f6618e3f46e40cc911e8 at: https://685cf729c6effd6ff02c4bc2--layer5.netlify.app

l5io avatar Jun 26 '25 07:06 l5io

@vishalvivekm Changes done. You can merge it!

KrishnaShuk avatar Jun 29 '25 04:06 KrishnaShuk

@KrishnaShuk Thank you for your contribution! Let's discuss this during the website call today at 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

vr-varad avatar Jun 30 '25 11:06 vr-varad

Thanks @zihanKuang. Will surely implement the feedback.

KrishnaShuk avatar Jul 06 '25 03:07 KrishnaShuk

If this work is complete, this is a good item to add to the weekly Websites meeting agenda. You can add this item in the doc, attend, and present it. Meeting details at https://meet.layer5.io.

leecalcote avatar Jul 07 '25 03:07 leecalcote

Sure @leecalcote , but some finishing work is left. Soon complete it within this day.

KrishnaShuk avatar Jul 07 '25 03:07 KrishnaShuk

Hi @KrishnaShuk, did you attend today's meeting? Were there any suggestions?😊

zihanKuang avatar Jul 07 '25 14:07 zihanKuang

Sorry, was not able to attend the meeting as I was away from my system due to some unavoidable work. But I have added the PR for next week agenda list.

KrishnaShuk avatar Jul 07 '25 14:07 KrishnaShuk

🚀 Preview for commit 7627d41077769b13bd79a9dfb375eee59801f25f at: https://686cd4ee2144423f3d598a82--layer5.netlify.app

l5io avatar Jul 08 '25 08:07 l5io

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 18 '25 23:07 stale[bot]

🚀 Preview for commit 51ad3267fe092081f430967c5283b450d0cce595 at: https://687cb804fb5c2b6db5941b5d--layer5.netlify.app

l5io avatar Jul 20 '25 09:07 l5io