layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

fix/Multiple-Overlapping-Tooltips-Appear-on-Hover#6445

Open abbiekuma opened this issue 6 months ago • 12 comments

Description

This PR fixes #6445

Notes for Reviewers

Signed commits

  • [✅] Yes, I signed my commits.

abbiekuma avatar Jun 10 '25 01:06 abbiekuma

🚀 Preview for commit 294474974ddf5ba46fbf865b392bb0165a75254a at: https://684786ba70e65ad94994bfba--layer5.netlify.app

l5io avatar Jun 10 '25 01:06 l5io

image Hi @abbiekuma I am not seeing service mesh interface compliance table on the deployed link, can you check?

LibenHailu avatar Jun 10 '25 14:06 LibenHailu

image Hi @abbiekuma I am not seeing service mesh interface compliance table on the deployed link, can you check?


Hi @LibenHailu ! While working on the feature, I noticed that the Service Mesh Interface compliance table doesn’t appear unless data is successfully fetched from the API due to CORS restrictions. To address this and make the component visible during development, I used src/collections/landscape/smi.js/smi_data as mock data to view the table, and the issue was successfully resolved in my local environment.

https://github.com/user-attachments/assets/994bc05b-2923-48e8-aea3-e30454dc6526

abbiekuma avatar Jun 10 '25 17:06 abbiekuma

local environment.

@abbiekuma Hmm, it doesn't seem to be working in production. Could you take a look and see what might be causing the issue?

LibenHailu avatar Jun 11 '25 14:06 LibenHailu

Just to clarify, when you say it’s not working, are you referring to the table still being missing, or the hover overlap issue still persists?

abbiekuma avatar Jun 11 '25 14:06 abbiekuma

Just to clarify, when you say it’s not working, are you referring to the table still being missing, or the hover overlap issue still persists?

The table is missing, here is the preview, https://684786ba70e65ad94994bfba--layer5.netlify.app/service-mesh-landscape

LibenHailu avatar Jun 11 '25 14:06 LibenHailu

The reason you're not seeing the SMI table is becuase the data fetch is being blocked by a CORS policy. For now, I’m using mock data locally so I can continue development so that's why it shows up on my end but not yours. Screenshot 2025-06-11 at 10 47 53 AM

abbiekuma avatar Jun 11 '25 16:06 abbiekuma

The reason you're not seeing the SMI table is becuase the data fetch is being blocked by a CORS policy. For now, I’m using mock data locally so I can continue development so that's why it shows up on my end but not yours.

Can you load the data locally? if not we have to check the backend and update the CORS policy?

LibenHailu avatar Jun 11 '25 18:06 LibenHailu

Hello, I I followed the suggestion at Slack to open a new Chrome window with security options disabled. This bypassed the CORS restrictions, and it worked! the data loaded successfully. Here is the updated recording👇

https://github.com/user-attachments/assets/628eeebb-78d7-4b49-9243-878fe889c8b0

abbiekuma avatar Jun 12 '25 17:06 abbiekuma

LGTM

LibenHailu avatar Jun 13 '25 07:06 LibenHailu

@abbiekuma Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar Jun 16 '25 11:06 vishalvivekm

🚀 Preview for commit 23e57555b32bc98f78e82af7f8d0d6ff5e85becd at: https://684ffe1d08ec02c8f6f58afe--layer5.netlify.app

l5io avatar Jun 16 '25 11:06 l5io

🚀 Preview for commit e5f02bab508dae3fa7dc3cf7062ee0bfc317c3a4 at: https://68599115186515835549a12c--layer5.netlify.app

l5io avatar Jun 23 '25 17:06 l5io

Here is how it looks in mobile view. @vishalvivekm @vr-varad I also updated the format. The previous formatting was changed by Prettier, but I’ve now adjusted it back to the original style.

https://github.com/user-attachments/assets/e564de81-b7d8-4e0f-ad0d-b40d9b072040

abbiekuma avatar Jun 23 '25 17:06 abbiekuma

🚀 Preview for commit 749aa4c889b56648ee67753300c80bcf2c0f3d60 at: https://685bcee22a8410e58b79bf5e--layer5.netlify.app

l5io avatar Jun 25 '25 10:06 l5io