layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Ensure Full Command Visibility in Installation Terminal

Open Jeffrin2005 opened this issue 7 months ago β€’ 13 comments

Description

The command box was long for the box, users needs to scroll horizontally to see the entire command. This is inconvenient because users couldn't see the full command at once.

https://layer5.io/cloud-native-management/meshery/getting-started

https://github.com/user-attachments/assets/f16e0f2e-1a29-463e-b648-0f5a9bae532d

Expected Behavior

Making the box wider so the entire command fits without scrolling

https://github.com/user-attachments/assets/2bbbb4a0-36c8-4ef1-b954-8057d41e3524

Screenshots

Environment:

  • Host OS:
  • Browser:

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

Jeffrin2005 avatar May 24 '25 11:05 Jeffrin2005

Good First issue.

Jeffrin2005 avatar May 24 '25 11:05 Jeffrin2005

can i take this issue ?

divyansh-prks avatar May 24 '25 14:05 divyansh-prks

Can this be assigned to me

huzfm avatar May 25 '25 04:05 huzfm

@ashok-2003 You could work on this

vr-varad avatar May 26 '25 19:05 vr-varad

I think this might break on smaller screens. Should we consider allowing the code to wrap into multiple lines to accommodate the full command? @vr-varad

ashok-2003 avatar May 26 '25 20:05 ashok-2003

ur call make a pr with this and lets see what can be done next

vr-varad avatar May 26 '25 20:05 vr-varad

sure :)

ashok-2003 avatar May 26 '25 20:05 ashok-2003

how this looks to you ? @vr-varad ,

https://github.com/user-attachments/assets/c3c06863-cfd7-453e-92b5-9671cc521ac4

ashok-2003 avatar May 27 '25 07:05 ashok-2003

it would be good if u open the pr to review what changes u made @ashok-2003

vr-varad avatar May 27 '25 07:05 vr-varad

@LibenHailu, we don't need this line-wrapped. Sticking with one line is ideal. It's ok if the overflow isn't visible. The scrollbar height can be cut in half and/or removed instead.

leecalcote avatar May 27 '25 12:05 leecalcote

Hi @leecalcote, I am having an issue with my laptop It is crashing when I try to run the project, I think the behavior is on chrome, It looks good on firefox, I think the behavior emerges from Highlight component, maybe @ashok-2003 have you tried it with the default props if it looks good we can stick to that, it should look something like this import Highlight, { defaultProps } from "prism-react-renderer"; <Highlight {...defaultProps} theme={theme} code={code} language="jsx">

LibenHailu avatar May 27 '25 21:05 LibenHailu

Hey @LibenHailu, for the issue you're facing, you might want to check the Slack conversation β€” it could be helpful. Also, thanks for your suggestion! I'll try implementing it and let you know how it goes.

ashok-2003 avatar May 29 '25 15:05 ashok-2003

Thank you @ashok-2003!

LibenHailu avatar May 29 '25 15:05 LibenHailu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

Closed in support of: https://github.com/layer5io/layer5/pull/6494#issuecomment-3015124617

vishalvivekm avatar Jun 28 '25 08:06 vishalvivekm