layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Add navigation link for kanvas section on layer5 website

Open LibenHailu opened this issue 7 months ago • 16 comments

Description

This PR fixes #6485

Notes for Reviewers Add navigation for kanvas section.

Signed commits

  • [x] Yes, I signed my commits.

LibenHailu avatar May 23 '25 19:05 LibenHailu

🚀 Preview for commit 25be30f35118095227595276e2c7010f68044155 at: https://6830cf744cb23a0074f8caf9--layer5.netlify.app

l5io avatar May 23 '25 19:05 l5io

Thank you @LibenHailu 🙌

do you have any ideas/suggestions on making this more intuitive to users? maybe changing the cursor pointer settings on hover?

is it intuitive that you can go to the docs, on-click?

these are just some general ux improvements that we could make.

let me know if you have any ideas.

M-DEV-1 avatar May 24 '25 05:05 M-DEV-1

@LibenHailu, please sign off your commits ^^

M-DEV-1 avatar May 24 '25 05:05 M-DEV-1

Hi @M-DEV-1, It is important that links are distinguishable from UX perspective, there are many approach to take for that like underlined text to tell to users it is not text it is a link or using cursor pointer style or putting link icons aside, for our case we can definitely go with the cursor pointer style, one major problem can be this is not applied on mobile screens, hoping out users are developers in my opinion if we go with the cursor: pointer style we will be good.

I think linking the docs there is a good UX improvement, from user perspective, I dont have any additions on this at the moment.

LibenHailu avatar May 24 '25 08:05 LibenHailu

🚀 Preview for commit ac040e343bbbb7899a7b5c5318ff521559df19d1 at: https://6831821c47913f457d1c8a9e--layer5.netlify.app

l5io avatar May 24 '25 08:05 l5io

Hi @LibenHailu, small spelling error to fix image

M-DEV-1 avatar May 26 '25 12:05 M-DEV-1

hi @LibenHailu, have you incorporated the feedback given earlier?

M-DEV-1 avatar May 28 '25 12:05 M-DEV-1

@LibenHailu, any updates?

M-DEV-1 avatar Jun 04 '25 13:06 M-DEV-1

https://github.com/layer5io/layer5/pull/6486/commits/25be30f35118095227595276e2c7010f68044155

This commit is causing the DCO check to fail ^^

M-DEV-1 avatar Jun 04 '25 13:06 M-DEV-1

@LibenHailu, any updates? @M-DEV-1 I am having an issue running the project, we are planning to gather the number of the people who are having the issue, and we are planning to come-up with a work-around for the issue if the number is big, we also collect what is working for people, so far I think it is codespaces which I don't have access to at the moment.

LibenHailu avatar Jun 04 '25 13:06 LibenHailu

why dont u put that issue in slack?? @LibenHailu

vr-varad avatar Jun 04 '25 13:06 vr-varad

why dont u put that issue in slack?? @LibenHailu

I was thinking about sending a poll on slack, the bot should be installed I reached out to some people, I will do it as soon as I get access to the poll, The idea is to know how many people are struggling to contribute due to the heavy contents we have, the question might look like Are you having an issue running the project, the choices will be yes and no, that way we can know the magnitude of the problem, in quantifiable amount, what do you think @vr-varad ?

LibenHailu avatar Jun 04 '25 13:06 LibenHailu

I was thinking about sending a poll on slack, the bot should be installed I reached out to some people, I will do it as soon as I get access to the poll, The idea is to know how many people are struggling to contribute due to the heavy contents we have, the question might look like Are you having an issue running the project, the choices will be yes and no, that way we can know the magnitude of the problem, in quantifiable amount, what do you think @vr-varad ?

Hmm, okay. That works too. If you have a student ID, you should claim GitHub PRO and use 32 GB codespaces. Let's see what can be done for now. Message in #support with the exact issue, and the issue after trying out selective rendering.

M-DEV-1 avatar Jun 04 '25 13:06 M-DEV-1

@LibenHailu Discuss that in todays' meet

vr-varad avatar Jun 04 '25 14:06 vr-varad

@LibenHailu Discuss that in todays' meet

Sorry @vr-varad I am just seeing this.

LibenHailu avatar Jun 04 '25 15:06 LibenHailu

ort with the exact issue, and the issue after trying out selective rendering.

But I will post on support, unforunately I dont have student ID.

LibenHailu avatar Jun 04 '25 15:06 LibenHailu

@LibenHailu are you able to work on this?

M-DEV-1 avatar Jun 25 '25 15:06 M-DEV-1

@LibenHailu?

M-DEV-1 avatar Jun 27 '25 08:06 M-DEV-1

@LibenHailu the dco is failing and is there any update on this??

vr-varad avatar Jun 28 '25 07:06 vr-varad

@M-DEV-1 @vr-varad missed this issue, I will work on it.

LibenHailu avatar Jun 29 '25 13:06 LibenHailu

@LibenHailu I think the link should be unnderlined , and also there is a spelling mistake on the Kanvas the k should be capital

Ayushmore1214 avatar Jun 30 '25 11:06 Ayushmore1214

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 04 '25 20:07 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Jul 04 '25 20:07 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.

Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

repliacted the changes and merged: https://github.com/layer5io/layer5/pull/6608, Thank you @LibenHailu

vishalvivekm avatar Jul 04 '25 21:07 vishalvivekm