Fixed button to scroll back to original expanded position

[ivioje]

Description

This PR fixes #6417

Notes for Reviewers Fixed button to scroll back to original expanded position

Signed commits

• [x] Yes, I signed my commits.

[l5io]

🚀 Preview for commit 6e0f3115369fc4ead6099dd27ab6351b3e932bac at: https://68142a7d721d8695e56b885c--layer5.netlify.app

[carlosriosilva]

Thanks, @ivioje! @sudhanshutech, will you be reviewing this one?

[Jeffrin2005]

@ivioje Everything is working good. Just for a suggestion not related the original issue , if we are expanding more than one card - as we can see in this video , the previously opened thing is collapsed, so for addressing multiple expansion card , can we do anything,

https://github.com/user-attachments/assets/63859f99-4798-4d5d-9deb-cb6c56e733de

No need to do any commits until the core team member review this PR.

[ivioje]

@ivioje Everything is working good. Just for a suggestion not related the original issue , if we are expanding more than one card - as we can see in this video , the previously opened thing is collapsed, so for addressing multiple expansion card , can we do anything,

16-fix.mp4 No need to do any commits until the code team member review this PR.

Thanks! Yes, something can be done. I can try using getBoundingClientRect() for accurate positioning and also directly reference the current card instead of its container.

[M-DEV-1]

Screencast from 2025-05-04 13-10-17.webm

@ivioje, there's an issue while trying to open multiple cards after row 2

[ivioje]

@ivioje Everything is working good. Just for a suggestion not related the original issue , if we are expanding more than one card - as we can see in this video , the previously opened thing is collapsed, so for addressing multiple expansion card , can we do anything,

16-fix.mp4 No need to do any commits until the core team member review this PR.

Screencast.from.2025-05-04.13-10-17.webm @ivioje, there's an issue while trying to open multiple cards after row 2

@M-DEV-1 yes, that's what @Jeffrin2005 observed too. Do I have a go ahead to fix it?

[M-DEV-1]

Yes, go for it @ivioje, thanks!!

[M-DEV-1]

Also, I couldn’t seem to replicate this issue on mobile when I tested, but maybe you could also give it a try on your side to double-check.

[ivioje]

Also, I couldn’t seem to replicate this issue on mobile when I tested, but maybe you could also give it a try on your side to double-check.

It works fine on mobile.

[ivioje]

Yes, go for it @ivioje, thanks!!

Done! I've updated the pull request. Thanks!

[github-actions[bot]]

View in catalog, Edit in playground or learn how to interpret Meshery Designs

[l5io]

🚀 Preview for commit 9e090fb814e5fe51880191f865281263c3a71390 at: https://68187cb23e44f3c7fdb12194--layer5.netlify.app

[vishalvivekm]

@ivioje Thank you for your contribution! Let's discuss this during the website call today at 7 AM CT.

Add it as an agenda item to the meeting minutes, if you would :)

[l5io]

🚀 Preview for commit a0b8ab44bfd225766e7a4211af39773445172690 at: https://681893ab7d36f745ee489b38--layer5.netlify.app

[l5io]

🚀 Preview for commit 80b4878baf387baa8394d4269fdb4990ae5bde94 at: https://6818a15a7c748655ee862edd--layer5.netlify.app

[ivioje]

Hello @vishalvivekm! I'm just curious, is there a pending task on my end that makes this PR still open?

[leecalcote]

@Jeffrin2005], perhaps, you can help tie this off....

[Jeffrin2005]

@ivioje lgtm, but a minor issue that i figured out is , when we are expanding the multiple cards but by maintaing the first card without closing it, as you can see, we are going downward to expand the second item, ( though the first expanded card will be collpased )

https://github.com/user-attachments/assets/8f291d99-872c-46b8-9ee1-117545f59faa

cc : @vishalvivekm @vr-varad

[ivioje]

@ivioje lgtm, but a minor issue that i figured out is , when we are expanding the multiple cards but by maintaing the first card without closing it, as you can see, we are going downward to expand the second item, ( though the first expanded card will be collpased )

tes1.mp4 cc : @vishalvivekm @vr-varad

Hello @Jeffrin2005. I don't see any issue in this. Perhaps you could explain clearly?

The downward movement is so because the previously opened card closes when the current card is opened. As you can see from the screencast you sent, the previous card has a longer height with more content. Therefore, when it closes, the current card scrolls into the view. the downward movement is because of the height of the previous workshop card.

If you expand a card above, it won't have the same behaviour. Also, if you expand a card with a smaller height the downward movement won't be visible.

This works fine to me.

[Jeffrin2005]

@ivioje Oh, got it! My bad : ) Everything else looks good to me.

[vr-varad]

@Jeffrin2005 is this is issue all good to go??

[Jeffrin2005]

@vr-varad yeah. Everything is good.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[M-DEV-1]

Hi @ivioje @Jeffrin2005, are there any more changes to do here?

[ivioje]

Hi @ivioje @Jeffrin2005, are there any more changes to do here?

Hi @M-DEV-1. There's no pending change on my end. Thanks.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[l5io]

🚀 Preview for commit f426a8d73a265a2707531faba12c65153cc0fc48 at: https://687cb7ac8045b4638cb57724--layer5.netlify.app

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[l5io]

🚀 Preview for commit bd9a0b569d448f471a670e426e10817c83e406ff at: https://68e6ebecb4811757904fce28--layer5.netlify.app

[Namanv0509]

Closing this issue due to no response or update on it.