layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard
Published 1 month ago • verified publisher icon layer5io

fix: added special links to the mobile nav

Open rohansen856 opened this issue 8 months ago • 7 comments

Description

This PR fixes #5813

Notes for Reviewers As mentioned in the issue comment here, I have added all the special links that were present in the desktop navbar but previously not shown in mobile nav. Attaching screenshots fro reference:

  • Special links in desktop view: image

  • Special links in mobile navbar after the changes: Screenshot from 2025-04-30 02-40-59

  • One thing to note is that I refrained from impplementinng the hover effect that is in the desktop links as mobile view would not need the hover effects. Rest of the features are as is from the desktop view.

This PR is ready for review. Please let me know if there is any need for changes. Thanks.

CC: @amitamrutiya @vishalvivekm

Signed commits

  • [x] Yes, I signed my commits.

rohansen856 avatar Apr 29 '25 21:04 rohansen856

🚀 Preview for commit 7865a6e27b9ddcb9c9f84260dcbe2a0a8576298b at: https://681146c999a34746ec8b50b7--layer5.netlify.app

l5io avatar Apr 29 '25 21:04 l5io

Thanks! Happy to contribute @vladboisa !

rohansen856 avatar May 01 '25 19:05 rohansen856

@rohansen856

Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST | 7 AM CT

Add it as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar May 05 '25 10:05 vishalvivekm

View in catalog, Edit in playground or learn how to interpret Meshery Designs

github-actions[bot] avatar May 05 '25 12:05 github-actions[bot]

🚀 Preview for commit f2d1364e8a1edd3927ba109cddd87b7eb6e8211c at: https://6818b428612d93a37c311375--layer5.netlify.app

l5io avatar May 05 '25 12:05 l5io

🚀 Preview for commit e1e0241109507f2002db9717b38a7a7ac7c25239 at: https://6824a2e765e3b22609d7e5da--layer5.netlify.app

l5io avatar May 14 '25 14:05 l5io

@vishalvivekm As discussed in the previous meet, I have removed the duplicate pricing menu item from the mobile nav so that the mobile nav does not get too long and cause accessibility issue for users. Screenshot: image

Just removed the pricing menu item from the solutions section and kept it in Products section. Thanks.

rohansen856 avatar May 14 '25 14:05 rohansen856

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

🚀 Preview for commit 8c961c5e8e960faa9ec093157078bf8c0f5cc107 at: https://68b0158019d5b79c2146edc9--layer5.netlify.app

l5io avatar Aug 28 '25 08:08 l5io

This issue is fixed : https://github.com/layer5io/layer5/pull/6766

Namanv0509 avatar Sep 21 '25 09:09 Namanv0509