layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

add max-width to images on learnign-paths

Open Touriist opened this issue 7 months ago β€’ 3 comments

Current Behavior

The chapters in the learning paths have some humongous images, simply because they take up the full width of the container (width: 100%).

Image

Desired Situation

  • add a max-width

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

Touriist avatar Apr 28 '25 23:04 Touriist

Greetings, @Touriist ! Based on the issue mentioned, I believe the necessary changes should be made here:

https://github.com/layer5io/layer5/blob/711ee7a918088ec95d53d6ff90812564c377d210/src/components/Learn-Components/Card-Component/learn-card.style.js#L85-L88

Specifically, the following adjustments are required:

            max-width: 100%; { to Add max-width }
            object-fit: contain; { Ensures proper image scaling }

Please let me know if my understanding is accurate. I would be delighted to contribute and work on resolving this issue.

Thank you! 🌻

Jivi-this-side avatar Apr 29 '25 07:04 Jivi-this-side

Sure! @Jivi-this-side LGTM

vr-varad avatar Apr 29 '25 08:04 vr-varad

Greeetings, @vr-varad ! I have submitted the pull request for your review. I kindly request your valuable time to assess the proposed changes.

Thank you for your attention and consideration. I sincerely appreciate the opportunity to contribute. Wishing you a wonderful day ahead! Thank you ! 🌻

Jivi-this-side avatar Apr 29 '25 13:04 Jivi-this-side

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

hello @Touriist @vr-varad ,

Could I take up this issue.

HIMU-2001 avatar Jun 28 '25 06:06 HIMU-2001

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 00:07 stale[bot]

@HIMU-2001 Are u working on this? or want to?

vr-varad avatar Jul 20 '25 09:07 vr-varad

@vr-varad I could take it up.

HIMU-2001 avatar Jul 20 '25 10:07 HIMU-2001

Thanks @HIMU-2001

vr-varad avatar Jul 20 '25 10:07 vr-varad

Hi @vr-varad @Touriist

Could you please take a look at my PR https://github.com/layer5io/layer5/pull/6645

HIMU-2001 avatar Jul 20 '25 18:07 HIMU-2001

Please assign me this issue

Khushi379 avatar Jul 26 '25 22:07 Khushi379

Hi @Khushi379 ,

I already have a pr open for this issue, which is under review. You could find any other issue to contribute to.

HIMU-2001 avatar Jul 27 '25 03:07 HIMU-2001