add max-width to images on learnign-paths
Current Behavior
The chapters in the learning paths have some humongous images, simply because they take up the full width of the container (width: 100%).
Desired Situation
- add a max-width
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.
- π See contributing instructions.
- π¨ Wireframes and designs for Layer5 site in Figma (open invite)
- ππΎππΌ Questions: Discussion Forum and Community Slack.
Join the Layer5 Community by submitting your community member form.
Greetings, @Touriist ! Based on the issue mentioned, I believe the necessary changes should be made here:
https://github.com/layer5io/layer5/blob/711ee7a918088ec95d53d6ff90812564c377d210/src/components/Learn-Components/Card-Component/learn-card.style.js#L85-L88
Specifically, the following adjustments are required:
max-width: 100%; { to Add max-width }
object-fit: contain; { Ensures proper image scaling }
Please let me know if my understanding is accurate. I would be delighted to contribute and work on resolving this issue.
Thank you! π»
Sure! @Jivi-this-side LGTM
Greeetings, @vr-varad ! I have submitted the pull request for your review. I kindly request your valuable time to assess the proposed changes.
Thank you for your attention and consideration. I sincerely appreciate the opportunity to contribute. Wishing you a wonderful day ahead! Thank you ! π»
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
hello @Touriist @vr-varad ,
Could I take up this issue.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@HIMU-2001 Are u working on this? or want to?
@vr-varad I could take it up.
Thanks @HIMU-2001
Hi @vr-varad @Touriist
Could you please take a look at my PR https://github.com/layer5io/layer5/pull/6645
Please assign me this issue
Hi @Khushi379 ,
I already have a pr open for this issue, which is under review. You could find any other issue to contribute to.