layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Fix : Social Media Share Links are Not working

Open Jeffrin2005 opened this issue 8 months ago • 11 comments

Description

  • Fixes #6396
  • By clicking the social icons, it will redirect to the social links.

Merge Checklist

  • [x] Prep screenshot or demo video for changelog entry, and attach it to issue.

https://github.com/user-attachments/assets/672c7a32-ca3b-44f6-9b32-c2ab169d5006

  • [x] Request for Peer Reviews
  • [x] Completion of QA in Mobile Devices
  • [x] Completion of QA in Desktop Devices

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

Jeffrin2005 avatar Apr 26 '25 07:04 Jeffrin2005

🚀 Preview for commit 9f6d8e0f14bd34635e4498dce886f8c105114ef1 at: https://680c8b075319cfa12ef29d79--layer5.netlify.app

l5io avatar Apr 26 '25 07:04 l5io

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Apr 28 '25 10:04 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Apr 28 '25 10:04 github-actions[bot]

@Jeffrin2005 Please sign off the commits Let's also discuss this during the website call today at 5:30 PM IST

Added as an agenda item to the meeting minutes

vishalvivekm avatar Apr 28 '25 10:04 vishalvivekm

🚀 Preview for commit e80cc9a2da90d3511a29e1bb880255a65afaf15a at: https://680f5546dd51fd7cb89563bc--layer5.netlify.app

l5io avatar Apr 28 '25 10:04 l5io

🚀 Preview for commit 0cfda544289b31ea2d39045bffc6eab7329e15c6 at: https://6811d0c5b800200e687526c8--layer5.netlify.app

l5io avatar Apr 30 '25 07:04 l5io

🚀 Preview for commit d3aa29fb931e616e52bbfe7f2732bb4e1cd13824 at: https://6811d59d995b8d1e3d94da27--layer5.netlify.app

l5io avatar Apr 30 '25 07:04 l5io

🚀 Preview for commit 9ace942347584ab3e9cc7322f216872a30d7e3a9 at: https://681897303e44f3134cb1202d--layer5.netlify.app

l5io avatar May 05 '25 10:05 l5io

@Jeffrin2005 Let's discuss this today in sites call.

vishalvivekm avatar May 05 '25 11:05 vishalvivekm

@Jeffrin2005 can you resolve the merge conflict?

LibenHailu avatar Jun 18 '25 17:06 LibenHailu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

@LibenHailu I resolved the merge confict is this good to merge or need some changes.

vr-varad avatar Jun 27 '25 08:06 vr-varad

🚀 Preview for commit 86b659755f06176f3fdc44af934b87192f5380df at: https://685e5f662d68264ab9da114d--layer5.netlify.app

l5io avatar Jun 27 '25 09:06 l5io

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 18 '25 23:07 stale[bot]

Any Updates @Jeffrin2005

vr-varad avatar Jul 20 '25 09:07 vr-varad

Hi @vr-varad, This needs some change, for example, the Twitter share API is not correct. Other than that, since we don't have a window object before the build, the current URL will be empty; we need to find a solution to that. If @Jeffrin2005 is not working on it, I can take it over.

LibenHailu avatar Jul 20 '25 19:07 LibenHailu

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 29 '25 04:07 stale[bot]