layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Enhanced modal guidance documentation while maintaining consistency

Open Souradip121 opened this issue 8 months ago • 11 comments

Description

This PR fixes https://github.com/layer5io/layer5/issues/6292

Notes for Reviewers I have put consistent styling along with implementing guidance section and elaborating on the code section with basic imports

https://github.com/user-attachments/assets/613a4e0f-5e60-4877-b9a9-81999ef3deda

Signed commits

  • [ ] Yes, I signed my commits.

Souradip121 avatar Apr 13 '25 07:04 Souradip121

🚀 Preview for commit f884b6cc9fc5431827062202792506f96519c287 at: https://67fb66ccbdfde4787534c7b0--layer5.netlify.app

l5io avatar Apr 13 '25 07:04 l5io

🚀 Preview for commit f057d75d115545a604228fb6545e6a1e27532cf2 at: https://67fb6c6e97bede7b5df62f25--layer5.netlify.app

l5io avatar Apr 13 '25 07:04 l5io

@vishalvivekm kindly look into the PR

Souradip121 avatar Apr 13 '25 10:04 Souradip121

@Souradip121 Like discussed in previous meeting, reduce the image size, in overview section: image

vishalvivekm avatar Apr 14 '25 07:04 vishalvivekm

In the code section, Confirmation Modal has following: image

The Confirmation Modal, we currently have:

image

vishalvivekm avatar Apr 14 '25 07:04 vishalvivekm

Maybe we’d be better off moving the props details to the guidance section, and just adding a note in the code section pointing to it.

image

vishalvivekm avatar Apr 14 '25 07:04 vishalvivekm

🚀 Preview for commit 3d2e5f023908399880196f7f1e88cab0cd50718b at: https://67fcc996484bb4ba9bb445bc--layer5.netlify.app

l5io avatar Apr 14 '25 08:04 l5io

🚀 Preview for commit cefea031696a2e183c6328aa3bb113fa1b4b4ec9 at: https://67fd09c2d6a839683d6182f4--layer5.netlify.app

l5io avatar Apr 14 '25 13:04 l5io

🚀 Preview for commit 1f43d194fd97f28f6f607a3f1d508c66c0cc901c at: https://680535e297fe4783b18d6781--layer5.netlify.app

l5io avatar Apr 20 '25 18:04 l5io

🚀 Preview for commit 583dc2d05b8ec3cfb9255c6546e7603cbafd80e0 at: https://680626aac113236c196198e6--layer5.netlify.app

l5io avatar Apr 21 '25 11:04 l5io

@vishalvivekm @amitamrutiya lgtm, just i asked @Souradip121 the external styles added is not effecting else where but being used consistently

sudhanshutech avatar Apr 29 '25 04:04 sudhanshutech

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

@Souradip121 Please signoff.

vr-varad avatar Jun 28 '25 07:06 vr-varad

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 18 '25 23:07 stale[bot]

@Souradip121 Please SignOff

vr-varad avatar Jul 20 '25 09:07 vr-varad

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 29 '25 04:07 stale[bot]