layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[Sistent] Add Switch component to the sistent components page

Open M-DEV-1 opened this issue 8 months ago • 13 comments

Description

This PR fixes #5960

I've added the Switch component to the Sistent Components page with code examples, usage and guidance.

Notes for Reviewers

Signed commits

  • [x] Yes, I signed my commits.

M-DEV-1 avatar Apr 09 '25 14:04 M-DEV-1

🚀 Preview for commit 3a4450c9d2b82aa7b8cc6ade14b892169f1d58fc at: https://67f68128b244c6f132e32a86--layer5.netlify.app

l5io avatar Apr 09 '25 14:04 l5io

  1. Could Increase Visibility image
  2. Missing Tabs image
  3. Could Be aligned image

vr-varad avatar Apr 09 '25 14:04 vr-varad

Hey @M-DEV-1 some fixes

vr-varad avatar Apr 09 '25 14:04 vr-varad

Thanks @vr-varad for pointing these out, I'll fix them 🤝

I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

M-DEV-1 avatar Apr 09 '25 14:04 M-DEV-1

Thanks @vr-varad for pointing these out, I'll fix them 🤝

I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

I meann't I would look good if they were side by side but nevermind

vr-varad avatar Apr 09 '25 14:04 vr-varad

Thanks @vr-varad for pointing these out, I'll fix them 🤝 I'm not sure what you meant by 3., but I will be adding more switches in the same code block for better representation.

I meann't I would look good if they were side by side but nevermind

Yes, you're right. It would be better side by side, in the same block. I'll make those changes. Thanks.

M-DEV-1 avatar Apr 09 '25 14:04 M-DEV-1

@M-DEV-1 Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST

Add it as an agenda item to the meeting minutes, if you would :)

vishalvivekm avatar Apr 14 '25 08:04 vishalvivekm

Thank you for @vr-varad offering feedback here, :clap:

vishalvivekm avatar Apr 14 '25 08:04 vishalvivekm

🚀 Preview for commit 8f0d5d42fabc2ae386df25a6b83e6970aef5b528 at: https://67fcc9f59f81bdc6026cd179--layer5.netlify.app

l5io avatar Apr 14 '25 08:04 l5io

@M-DEV-1 are all the suggestions in here by @vr-varad and during last sites' call, incorporated?

vishalvivekm avatar Apr 21 '25 10:04 vishalvivekm

🚀 Preview for commit ff3b43d0c79a1323dacc0cf3c76969d5d0611c25 at: https://680627b848abe9f284a11437--layer5.netlify.app

l5io avatar Apr 21 '25 11:04 l5io

Thank you @Souradip121 for making these changes, however, a couple of them are still in need of being included in here.

vishalvivekm avatar Apr 21 '25 11:04 vishalvivekm

it looks good to me @vishalvivekm @amitamrutiya

sudhanshutech avatar Apr 29 '25 04:04 sudhanshutech

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 01:06 stale[bot]

@M-DEV-1 failing build / checks

vishalvivekm avatar Jun 28 '25 09:06 vishalvivekm

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 18 '25 23:07 stale[bot]

Any updates @M-DEV-1

vr-varad avatar Jul 20 '25 09:07 vr-varad

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 29 '25 04:07 stale[bot]