layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[Components] Add Table component and update navigation links

Open Souradip121 opened this issue 8 months ago • 7 comments

Description

This PR fixes https://github.com/layer5io/layer5/issues/5962

Notes for Reviewers

https://github.com/user-attachments/assets/52ea133c-a828-4e5a-ba90-050cb6e0d5f7

After observing the progress made by @eyeaadil, I noticed that there was usage of @mui/material in his PR https://github.com/layer5io/layer5/pull/6231, which should not be the case, as pointed out by @sudhanshutech in the review. After reading the PR, I also found that he had not implemented proper navigation after adding table, and had used props from @mui/material, not from @layer5/sistent. Then I began studying Table component of @layer5/sistent where I found there was no Stripped Table variant, no Bordered Cells variant. Therefore, I implemented the table component from Sistent without those variants and without any using Material UI. I am going to create an issue for adding those variants of Table in Sistent. Another thing I noticed after going through the documentation of sistent components like Select there was usage of @mui/material and no import of Select from layer5/sistent image

Signed commits

  • [x] Yes, I signed my commits.

Souradip121 avatar Apr 05 '25 11:04 Souradip121

🚀 Preview for commit 8a1b0d830b79534fc76117f02a170263887e963a at: https://67f11345ea4a3ebfac617338--layer5.netlify.app

l5io avatar Apr 05 '25 11:04 l5io

@Souradip121 Thank you for your contribution! Let's discuss this during the website call today at 5:30 PM IST

adding it as an agenda item to the meeting minutes.

vishalvivekm avatar Apr 07 '25 09:04 vishalvivekm

🚀 Preview for commit 98d1195f240f712f58a447a01dc333b5aee032e9 at: https://67f3a3fe901b4bd31b38b456--layer5.netlify.app

l5io avatar Apr 07 '25 10:04 l5io

🚀 Preview for commit 9fe7f9c2bbe15c70c3104383c200a94fc47acb17 at: https://67fb602a934d908cec982bb4--layer5.netlify.app

l5io avatar Apr 13 '25 06:04 l5io

image I have implemented ResponsiveDataTable @sudhanshutech But it is looking like this :)

Souradip121 avatar Apr 13 '25 10:04 Souradip121

image I have implemented ResponsiveDataTable @sudhanshutech But it is looking like this :)

@Souradip121 please add some data to these tables then it would look good, don't keep them empty

sudhanshutech avatar Apr 29 '25 04:04 sudhanshutech

atleast add these too(in guidance) @Souradip121 :

  1. What are options values...
  2. How to enable column sort
  3. what are multiselect and none select
  4. disabled row
  5. sub tables

sudhanshutech avatar Apr 29 '25 04:04 sudhanshutech

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 01:06 stale[bot]

Hi @sudhanshutech Are you still working on this issue? The work seems almost done here.

avni-mahajan avatar Aug 03 '25 05:08 avni-mahajan

@avni-mahajan If you want u can work on this issue!!!! and complete it off!!!

vr-varad avatar Aug 10 '25 21:08 vr-varad

@vr-varad, thank you and I will start working on this!

avni-mahajan avatar Aug 11 '25 07:08 avni-mahajan