layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Inconsistent Prop Naming in SectionTitle and Button Components

Open falgunmpatel opened this issue 9 months ago β€’ 5 comments

Description

There is inconsistency in prop naming conventions across the codebase:

  • $UniWidth is defined in the SectionTitle component, but UniWidth is used in several places instead of @$UniWidth.
  • $secondary is defined in the Button component, but many implementations use secondary instead.

Expected Behavior

  • Ensure that $UniWidth is used consistently as @$UniWidth.
  • Ensure that $secondary is used instead of secondary for consistency.

Tasks

  • [ ] Replace UniWidth with @$UniWidth where necessary.
  • [ ] Replace secondary with $secondary in relevant implementations.

Screenshots

Image Image

Environment:

  • Host OS:
  • Browser:

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

falgunmpatel avatar Mar 08 '25 19:03 falgunmpatel

@falgunmpatel i would like to resolve this issue

tanishq3105 avatar Mar 08 '25 19:03 tanishq3105

Hi @tanishq3105 Thanks for your interest in taking up this issue! Before assigning it, we need clarification on whether the incorrectly used props should be removed or renamed with a $ prefix, as renaming could impact the UI.

Once we get confirmation from the maintainers, I'll update you. Appreciate your patience!

falgunmpatel avatar Mar 08 '25 19:03 falgunmpatel

Hey @falgunmpatel any updates on this, would like to work on it if it's decided

heysubinoy avatar Apr 02 '25 05:04 heysubinoy

The issue is still there. can I be assigned to this? @vishalvivekm

Souradip121 avatar Apr 14 '25 12:04 Souradip121

@falgunmpatel any updates about it? I would like to work on this issue

lakshyajn avatar May 26 '25 17:05 lakshyajn

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

Hi @falgunmpatel, Any update on this? @vishalvivekm I would like to work on it if it's still open

Radha2786 avatar Aug 10 '25 18:08 Radha2786