Inconsistent Prop Naming in SectionTitle and Button Components
Description
There is inconsistency in prop naming conventions across the codebase:
- $UniWidth is defined in the SectionTitle component, but UniWidth is used in several places instead of @$UniWidth.
- $secondary is defined in the Button component, but many implementations use secondary instead.
Expected Behavior
- Ensure that $UniWidth is used consistently as @$UniWidth.
- Ensure that $secondary is used instead of secondary for consistency.
Tasks
- [ ] Replace UniWidth with @$UniWidth where necessary.
- [ ] Replace secondary with $secondary in relevant implementations.
Screenshots
Environment:
- Host OS:
- Browser:
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.
- π See contributing instructions.
- π¨ Wireframes and designs for Layer5 site in Figma (open invite)
- ππΎππΌ Questions: Discussion Forum and Community Slack.
Join the Layer5 Community by submitting your community member form.
@falgunmpatel i would like to resolve this issue
Hi @tanishq3105 Thanks for your interest in taking up this issue! Before assigning it, we need clarification on whether the incorrectly used props should be removed or renamed with a $ prefix, as renaming could impact the UI.
Once we get confirmation from the maintainers, I'll update you. Appreciate your patience!
Hey @falgunmpatel any updates on this, would like to work on it if it's decided
The issue is still there. can I be assigned to this? @vishalvivekm
@falgunmpatel any updates about it? I would like to work on this issue
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Hi @falgunmpatel, Any update on this? @vishalvivekm I would like to work on it if it's still open