[UI] Footer Repetition on Sistent/Components Page
Description
On sistent/components, after complete loading, the Footer seems to be shown twice, instead of once.
Expected Behavior
The footer should only be displayed once.
Screenshots
Environment:
- Host OS: Ubuntu 22.04
- Browser: Firefox, Brave
Contributor Resources and Handbook
The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.
- 📚 See contributing instructions.
- 🎨 Wireframes and designs for Layer5 site in Figma (open invite)
- 🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack.
Join the Layer5 Community by submitting your community member form.
I'd like to fix this along with #6243
@leecalcote Can I go ahead and fix this?
Hello @leecalcote , This was a hydration issue, and it has been fixed in PR #6287 by Falgun.
Can I work on this issue?
hey @swaparup36 are u able to setup layer5 repo locally? and able to regenerate the issue
@vr-varad I'm doing that
Hi, Can i work on this issue?
@swaparup36 No updates here?
Hi, Can i work on this issue?
@abbiekuma Sounds great. Thanks much for jumping in and volunteering. In an effort to help guarantee your success in undertaking assignment of the issue, will you:
- confirm that you're able to build the site.
- confirm the approach you intend to take to resolve the issue - a draft of the narrative would be great.
Hi @vishalvivekm
- I am able to build the site locally
- When we visit "sistent/components" the rendering of this page injects an addition footer due to re rendering which cause the double footer issue in all the pages across website. The twice appearing of the footer on all the pages (not just Sistent/Components) is due to re-rendering of the footer twice, i.e, in the "wrapPageElement" (page-wrapper. The fix needs to be implemented in the gatsby-ssr.js and the gatsby-browser.js
@vishalvivekm Sorry I was inactive, had some issues. You can assign it to anyone else
If its not assigned to anyone, i will be glad to work on it
Hi, Can i work on this issue?
@abbiekuma Sounds great. Thanks much for jumping in and volunteering. In an effort to help guarantee your success in undertaking assignment of the issue, will you:
- confirm that you're able to build the site.
- confirm the approach you intend to take to resolve the issue - a draft of the narrative would be great.
Thank you Vivek for reaching out! Yes, I'm able to build the site locally. My plan is to first reproduce and investigate the issue in my local environment. Once I have a clear understanding of the root cause, I will implement a fix by correcting the relevant logic in the code. After that, I’ll run tests to ensure the issue is resolved and that no other functionality is affected. I’ll then prepare a PR with the changes for review.
@leecalcote I discovered that this is a hydration issue. After reviewing the conversation above, I noticed that @GARY121github mentioned it was addressed in PR #6287 by @falgunmpatel.
@abbiekuma @leecalcote I have an observation that it's more than just a hydration issue, I think the components page is injected some global components because once the components page is viewed, the dual footer issue seems to appear on every other page of the website which is not the case otherwise, can we discuss this and my potential solution in the next meeting @leecalcote ?
I was working on other pages , and yes this is an hydration issue , not sure whats causing it but
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@vr-varad @vishalvivekm I would like to work on this issue. It seems that the issue has not yet been resolved. Can you please assign it to me?
@vr-varad @vishalvivekm, I would like to take this issue. Can you please assign it to me?
Any update on this @Radha2786
Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?
Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?
it is still present.
Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?
Confirm its present , only in sistent pages
Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?
Confirm its present , only in sistent pages
Hi, @vr-varad
I’d like to work on fixing this issue. Could you please assign it to me?
Hi, I’d like to take on this issue.
My local setup is working correctly and I was able to reproduce the problem on the Sistent/Components pages.
Could you please assign this issue to me? Thanks!
@Fireentity there is similar issue related to this assigned to someone please comment there and I'll assign you after confirmation #6806
Thanks, @Fireentity
I'm still working on both this and #6806 I'm still trying to find the error causing these issues