layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

[UI] Footer Repetition on Sistent/Components Page

Open M-DEV-1 opened this issue 10 months ago • 13 comments

Description

On sistent/components, after complete loading, the Footer seems to be shown twice, instead of once.

Expected Behavior

The footer should only be displayed once.

Screenshots

Image

Environment:

  • Host OS: Ubuntu 22.04
  • Browser: Firefox, Brave

Contributor Resources and Handbook

The layer5.io website uses Gatsby, React, and GitHub Pages. Site content is found under the master branch.

Join the Layer5 Community by submitting your community member form.

M-DEV-1 avatar Feb 17 '25 16:02 M-DEV-1

I'd like to fix this along with #6243

M-DEV-1 avatar Feb 17 '25 16:02 M-DEV-1

@leecalcote Can I go ahead and fix this?

GARY121github avatar Feb 24 '25 17:02 GARY121github

Hello @leecalcote , This was a hydration issue, and it has been fixed in PR #6287 by Falgun.

GARY121github avatar Mar 08 '25 19:03 GARY121github

Can I work on this issue?

swaparup36 avatar May 26 '25 13:05 swaparup36

hey @swaparup36 are u able to setup layer5 repo locally? and able to regenerate the issue

vr-varad avatar May 26 '25 13:05 vr-varad

@vr-varad I'm doing that

swaparup36 avatar May 27 '25 06:05 swaparup36

Hi, Can i work on this issue?

abbiekuma avatar Jun 02 '25 13:06 abbiekuma

@swaparup36 No updates here?

vishalvivekm avatar Jun 09 '25 03:06 vishalvivekm

Hi, Can i work on this issue?

@abbiekuma Sounds great. Thanks much for jumping in and volunteering. In an effort to help guarantee your success in undertaking assignment of the issue, will you:

  • confirm that you're able to build the site.
  • confirm the approach you intend to take to resolve the issue - a draft of the narrative would be great.

vishalvivekm avatar Jun 09 '25 03:06 vishalvivekm

Hi @vishalvivekm

  1. I am able to build the site locally
  2. When we visit "sistent/components" the rendering of this page injects an addition footer due to re rendering which cause the double footer issue in all the pages across website. The twice appearing of the footer on all the pages (not just Sistent/Components) is due to re-rendering of the footer twice, i.e, in the "wrapPageElement" (page-wrapper. The fix needs to be implemented in the gatsby-ssr.js and the gatsby-browser.js

aadarshx22 avatar Jun 09 '25 17:06 aadarshx22

@vishalvivekm Sorry I was inactive, had some issues. You can assign it to anyone else

swaparup36 avatar Jun 10 '25 19:06 swaparup36

If its not assigned to anyone, i will be glad to work on it

Namanv0509 avatar Jun 10 '25 22:06 Namanv0509

Hi, Can i work on this issue?

@abbiekuma Sounds great. Thanks much for jumping in and volunteering. In an effort to help guarantee your success in undertaking assignment of the issue, will you:

  • confirm that you're able to build the site.
  • confirm the approach you intend to take to resolve the issue - a draft of the narrative would be great.

Thank you Vivek for reaching out! Yes, I'm able to build the site locally. My plan is to first reproduce and investigate the issue in my local environment. Once I have a clear understanding of the root cause, I will implement a fix by correcting the relevant logic in the code. After that, I’ll run tests to ensure the issue is resolved and that no other functionality is affected. I’ll then prepare a PR with the changes for review.

abbiekuma avatar Jun 11 '25 02:06 abbiekuma

@leecalcote I discovered that this is a hydration issue. After reviewing the conversation above, I noticed that @GARY121github mentioned it was addressed in PR #6287 by @falgunmpatel.

abbiekuma avatar Jun 24 '25 22:06 abbiekuma

@abbiekuma @leecalcote I have an observation that it's more than just a hydration issue, I think the components page is injected some global components because once the components page is viewed, the dual footer issue seems to appear on every other page of the website which is not the case otherwise, can we discuss this and my potential solution in the next meeting @leecalcote ?

aadarshx22 avatar Jun 25 '25 16:06 aadarshx22

I was working on other pages , and yes this is an hydration issue , not sure whats causing it but

Namanv0509 avatar Jul 07 '25 09:07 Namanv0509

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 19 '25 00:07 stale[bot]

@vr-varad @vishalvivekm I would like to work on this issue. It seems that the issue has not yet been resolved. Can you please assign it to me?

AnushtupGhosh5 avatar Jul 20 '25 03:07 AnushtupGhosh5

@vr-varad @vishalvivekm, I would like to take this issue. Can you please assign it to me?

Radha2786 avatar Aug 11 '25 06:08 Radha2786

Any update on this @Radha2786

vr-varad avatar Aug 21 '25 09:08 vr-varad

Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?

Radha2786 avatar Aug 21 '25 14:08 Radha2786

Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?

it is still present.

saurabhraghuvanshii avatar Aug 23 '25 10:08 saurabhraghuvanshii

Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?

Confirm its present , only in sistent pages

Rajesh-Nagarajan-11 avatar Aug 23 '25 11:08 Rajesh-Nagarajan-11

Hi @vr-varad I tested the website on my localhost and I’m no longer seeing the issue. It seems to have been resolved earlier. Can you please confirm once?

Confirm its present , only in sistent pages

Rajesh-Nagarajan-11 avatar Aug 23 '25 11:08 Rajesh-Nagarajan-11

Hi, @vr-varad
I’d like to work on fixing this issue. Could you please assign it to me?

Dsmita03 avatar Sep 15 '25 13:09 Dsmita03

Hi, I’d like to take on this issue.
My local setup is working correctly and I was able to reproduce the problem on the Sistent/Components pages.

Could you please assign this issue to me? Thanks!

Fireentity avatar Sep 22 '25 10:09 Fireentity

@Fireentity there is similar issue related to this assigned to someone please comment there and I'll assign you after confirmation #6806

saurabhraghuvanshii avatar Sep 22 '25 11:09 saurabhraghuvanshii

Thanks, @Fireentity

marblom007 avatar Sep 29 '25 03:09 marblom007

I'm still working on both this and #6806 I'm still trying to find the error causing these issues

Fireentity avatar Oct 02 '25 20:10 Fireentity