layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Added the List component to the sistent components page and updated the content.js file.

Open csengineer1990 opened this issue 10 months ago • 10 comments

Description

This PR addresses issue #5951 by adding the List component to the Sistent Components page. The necessary content and documentation for the List component have been included, along with updates to the relevant files to ensure consistency.

This PR fixes #5951

Notes for Reviewers I have made the following changes:

  1. Implemented and documented the List component.
  2. Updated the content.js file to reflect these additions.

I have made the required changes as requested in the previous reviews and aligned them with the issue to ensure a proper resolution. I would appreciate your review of these updates. Please let me know if any further refinements or additional changes are needed. Thank you!

Signed commits

  • [x] Yes, I signed my commits.

csengineer1990 avatar Feb 02 '25 12:02 csengineer1990

🚀 Preview for commit 5c557f3a5351d725e48b171220713252811d771e at: https://679f638e6e5e0b86aee4c955--layer5.netlify.app

l5io avatar Feb 02 '25 12:02 l5io

@csengineer1990 Thank you for your contribution! Let's discuss this during the website call on Monday at 6:30 PM IST

adding it as an agenda item to the meeting minutes.

vishalvivekm avatar Feb 03 '25 09:02 vishalvivekm

Made the requested changes by adding examples of List control with checkboxes and removing code-block.js. Apologies for the delayed update. If any further changes are needed, please let me know.

csengineer1990 avatar Feb 15 '25 12:02 csengineer1990

🚀 Preview for commit 2a9bd7429b325c1e6f0b15e224a26d7bbeb8e9b5 at: https://67b08c32b7f3d319c41cfb1e--layer5.netlify.app

l5io avatar Feb 15 '25 12:02 l5io

@csengineer1990 please have a look at the merge conflicts here.

leecalcote avatar Feb 20 '25 05:02 leecalcote

@csengineer1990 please have a look at the merge conflicts here.

Yes, I will surely resolve the merge conflicts as soon as possible. Thanks for bringing it to my attention!

csengineer1990 avatar Feb 21 '25 04:02 csengineer1990

🚀 Preview for commit fefa97898cbc55df5788870e68ad11959b706d43 at: https://67b954e04b59d7b097203a3b--layer5.netlify.app

l5io avatar Feb 22 '25 04:02 l5io

I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible.

csengineer1990 avatar Feb 27 '25 03:02 csengineer1990

I have resolved the merge conflict. Please review the commit and let me know if there are any issues so that I can address them as soon as possible.

csengineer1990 avatar Mar 11 '25 03:03 csengineer1990

Approved 👍 Add this as an agenda item to the meeting minutes.

Hi, I’ve resolved the merge conflict and pushed the updated commit. Kindly review when possible — if everything looks good, please consider merging it. If there’s anything I’ve missed or done incorrectly, please let me know and I’ll fix it right away. It’s been a while, so just following up. Thanks!

csengineer1990 avatar Apr 10 '25 03:04 csengineer1990

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 27 '25 00:06 stale[bot]

Hey @csengineer1990, Is this done from your side? There are merge conflict that you might need to resolve.

vr-varad avatar Aug 22 '25 06:08 vr-varad

Hey @csengineer1990, Is this done from your side? There are merge conflict that you might need to resolve.

Hi, I had completed this issue earlier and at that time everything was working fine. I haven’t re-downloaded the repo recently, but from the GitHub checks it looks like there are no merge conflicts and the branch can be merged. Please let me know if you still need me to make any additional updates.

csengineer1990 avatar Aug 24 '25 03:08 csengineer1990

any updates ?

Rajesh-Nagarajan-11 avatar Sep 23 '25 15:09 Rajesh-Nagarajan-11

Due to unwanted changes in feature_data.json + No response from authour leads to close this PR

Rajesh-Nagarajan-11 avatar Oct 02 '25 16:10 Rajesh-Nagarajan-11