layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

Link component

Open NishantSinghhhhh opened this issue 1 year ago β€’ 4 comments

Description

Component Name : Link component present in Sistent component folder ,

This PR addresses various enhancements and features, including:

Documentation : I have written Documentation for the Link Component Used in Sistent Repository Link Variants: Added different styles for links, including underlined and colored versions to enhance navigation and visibility.

Security Practices: Documented best practices for using links with target="_blank", highlighting the importance of rel="noopener" and rel="noreferrer" attributes to improve security.

Notes for Reviewers

Please pay special attention to the documentation and security notes for external links. Feedback on these changes would be greatly appreciated.

Signed commits**

Yes, I signed my commits.

NishantSinghhhhh avatar Oct 21 '24 06:10 NishantSinghhhhh

πŸš€ Preview for commit dfa383668286321f8315b865bc68c335c4fc7e57 at: https://6715fb00a753f1fc9c4fac02--layer5.netlify.app

l5io avatar Oct 21 '24 06:10 l5io

πŸš€ Preview for commit 3465ed85bf57879e4cbb8922748f9615ebb8df50 at: https://6716033edc3fa002dc000554--layer5.netlify.app

l5io avatar Oct 21 '24 07:10 l5io

@NishantSinghhhhh I added the item to the docs: https://docs.google.com/document/d/1XczAHXVe2FIWPqiF57ospJ43zw5cZQ7ui8mn39v5EvA/edit?tab=t.0

vishalvivekm avatar Oct 21 '24 11:10 vishalvivekm

@vishalvivekm thank you so much Sir

NishantSinghhhhh avatar Oct 21 '24 11:10 NishantSinghhhhh

πŸš€ Preview for commit b0d80fde3c9494e9e24b41730864b2d52b9f0afe at: https://67167a8c43c3d76be6961631--layer5.netlify.app

l5io avatar Oct 21 '24 16:10 l5io

πŸš€ Preview for commit e994890d9fc547c41bf5332fff001c9c0b029022 at: https://671681a0c892347e07f863a7--layer5.netlify.app

l5io avatar Oct 21 '24 16:10 l5io

πŸš€ Preview for commit 1dbe06a9e8b1afdb3730eadbad57f111d91cea78 at: https://67168a6c907aac827f285595--layer5.netlify.app

l5io avatar Oct 21 '24 17:10 l5io

I have implemented the necessary changes as requested in the meet #6015 Please review the updates, and if everything meets the project requirements, I would appreciate your help in merging the PR

NishantSinghhhhh avatar Oct 21 '24 18:10 NishantSinghhhhh

πŸš€ Preview for commit e11cdb4a86a2382811b932f8d5844c1f022c42d3 at: https://67173635c015755baff8bf8c--layer5.netlify.app

l5io avatar Oct 22 '24 05:10 l5io

πŸš€ Preview for commit 63d5022acf74477228f381872ee27e03f3f6d044 at: https://671748c932848974d5d28df5--layer5.netlify.app

l5io avatar Oct 22 '24 06:10 l5io

πŸš€ Preview for commit 34692aef3675a85f8e6cb662f38a9488d852b83c at: https://67175cbd20e23e8a978c8e97--layer5.netlify.app

l5io avatar Oct 22 '24 08:10 l5io

πŸš€ Preview for commit 5685b9462026f6534b5882584806433bded1a1c0 at: https://671762903e850f867cc74570--layer5.netlify.app

l5io avatar Oct 22 '24 08:10 l5io

πŸš€ Preview for commit 0cf978c3c0e5a97d89dc32ccf3f2f4e854f5e495 at: https://671768518c4e2890167f2ba2--layer5.netlify.app

l5io avatar Oct 22 '24 08:10 l5io

πŸš€ Preview for commit 0eb84e759e2b3df9df7d8689eb406ee566e04812 at: https://67177692c3a49aabdde6cabd--layer5.netlify.app

l5io avatar Oct 22 '24 09:10 l5io

@sudhanshutech , Sir I have done the changes you asked for

NishantSinghhhhh avatar Oct 22 '24 10:10 NishantSinghhhhh

πŸš€ Preview for commit 862f881c2e8adb297c66cc0f0740ac09ad1a41e2 at: https://67178f868771dac5ab505ab9--layer5.netlify.app

l5io avatar Oct 22 '24 11:10 l5io

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


Β  Β  Β  Β  Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Oct 22 '24 11:10 github-actions[bot]

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


Β  Β  Β  Β  Be sure to join the community, if you haven't yet and please leave a :star: star on the project :smile:

github-actions[bot] avatar Oct 22 '24 11:10 github-actions[bot]

πŸš€ Preview for commit 8a4b8552586a07d32ea186fdf267744b96f09fa4 at: https://6717a2a150aba319f1ec9459--layer5.netlify.app

l5io avatar Oct 22 '24 13:10 l5io

πŸš€ Preview for commit 28a9d395d7a5326e7e6f4aa3437595146b89b90d at: https://6717a9e6fb455c2506a57fc9--layer5.netlify.app

l5io avatar Oct 22 '24 13:10 l5io

πŸš€ Preview for commit a284eee67254138cf7dc574d9d53e0f912087e96 at: https://6717e2f552118e7e27667c8b--layer5.netlify.app

l5io avatar Oct 22 '24 17:10 l5io

@sudhanshutech ,DCO issue is now removed

NishantSinghhhhh avatar Oct 22 '24 18:10 NishantSinghhhhh

πŸš€ Preview for commit eb4dbf80c8d172ed8ccfd466d6603c6983199490 at: https://6718b156b7a10f825732289b--layer5.netlify.app

l5io avatar Oct 23 '24 08:10 l5io

Are there any other changes required that makes my codeΒ suitable to merge it in the main branch

NishantSinghhhhh avatar Oct 23 '24 15:10 NishantSinghhhhh

πŸš€ Preview for commit eb7ea29ce00e56b5ac45118f63cc42adcea0f185 at: https://67192c2db663b33fc5031454--layer5.netlify.app

l5io avatar Oct 23 '24 17:10 l5io

@NishantSinghhhhh Can you update your fork by resolving the confilct?

nebula-aac avatar Oct 24 '24 12:10 nebula-aac

@nebula-aac , Sir I just resolved the conflicts , now it can be merged as it is free from conflicts

NishantSinghhhhh avatar Oct 24 '24 13:10 NishantSinghhhhh

πŸš€ Preview for commit f5ebd918a352958f5ad867be1238a8bc95beb3c9 at: https://671a51bda22f2904dedec717--layer5.netlify.app

l5io avatar Oct 24 '24 13:10 l5io

@nebula-aac @sudhanshutech , Sir I have deleted the code-block.js and used an already made component

NishantSinghhhhh avatar Oct 24 '24 14:10 NishantSinghhhhh

πŸš€ Preview for commit b13dece31a1d097f3450f9a6ac1949d2369b0a90 at: https://671e132181a5f42297d489a5--layer5.netlify.app

l5io avatar Oct 27 '24 10:10 l5io