layer5 icon indicating copy to clipboard operation
layer5 copied to clipboard

added documentation of Link Component

Open NishantSinghhhhh opened this issue 1 year ago • 5 comments

Description

Component Name : Link component present in Sistent component folder ,

This PR addresses various enhancements and features, including:

Documentation : I have written Documentation for the Link Component Used in Sistent Repository Link Variants: Added different styles for links, including underlined and colored versions to enhance navigation and visibility.

Security Practices: Documented best practices for using links with target="_blank", highlighting the importance of rel="noopener" and rel="noreferrer" attributes to improve security.

Notes for Reviewers

Please pay special attention to the documentation and security notes for external links. Feedback on these changes would be greatly appreciated.

preview: Screenshot 2024-10-20 235214

Signed commits**

Yes, I signed my commits.

NishantSinghhhhh avatar Oct 20 '24 21:10 NishantSinghhhhh

@NishantSinghhhhh Thank you for your contribution! Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

vishalvivekm avatar Oct 21 '24 01:10 vishalvivekm

@NishantSinghhhhh Can you check and fix the errors due to the github actions job?

https://github.com/layer5io/layer5/actions/runs/11429709327/job/31796389728

nebula-aac avatar Oct 21 '24 02:10 nebula-aac

@vishalvivekm Sir I am not able to edit the doc that you put in your previous comment ,thus I am not able to add my name in it

NishantSinghhhhh avatar Oct 21 '24 06:10 NishantSinghhhhh

@nebula-aac https://github.com/layer5io/layer5/pull/6015 , I have created 1 more PR that passes all the test except the kanvas test , can you please review it Screenshot 2024-10-21 124816

NishantSinghhhhh avatar Oct 21 '24 07:10 NishantSinghhhhh

Duplicate of https://github.com/layer5io/layer5/pull/6015

vishalvivekm avatar Oct 21 '24 11:10 vishalvivekm